From: Mike Frysinger <vapier@gentoo.org>
To: libc-ports@sourceware.org
Subject: [patch] handle unaligned arm abs relocs
Date: Tue, 13 Dec 2011 00:20:00 -0000 [thread overview]
Message-ID: <201112121920.17908.vapier@gentoo.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
background can be found here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51456
patch is below
-mike
2011-12-12 Mike Frysinger <vapier@gentoo.org>
* dl-machine.h (elf_machine_rel, R_ARM_ABS32): Declare "reloc_value".
Replace reloc_addr addition with memcpy's.
diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h
index 5ceeaa9..fe64800 100644
--- a/sysdeps/arm/dl-machine.h
+++ b/sysdeps/arm/dl-machine.h
@@ -413,6 +413,7 @@ elf_machine_rel (struct link_map *map, const Elf32_Rel
*reloc,
break;
case R_ARM_ABS32:
{
+ Elf32_Addr reloc_value;
# ifndef RTLD_BOOTSTRAP
/* This is defined in rtld.c, but nowhere in the static
libc.a; make the reference weak so static programs can
@@ -431,7 +432,10 @@ elf_machine_rel (struct link_map *map, const Elf32_Rel
*reloc,
used while loading those libraries. */
value -= map->l_addr + refsym->st_value;
# endif
- *reloc_addr += value;
+ /* Support relocations on mis-aligned offsets. */
+ memcpy (&reloc_value, reloc_addr_arg, sizeof (reloc_value));
+ reloc_value += value;
+ memcpy (reloc_addr_arg, &reloc_value, sizeof (reloc_value));
break;
}
case R_ARM_TLS_DESC:
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-12-13 0:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 0:20 Mike Frysinger [this message]
2011-12-14 22:05 ` Carlos O'Donell
2011-12-14 22:29 ` Mike Frysinger
2011-12-14 22:44 ` Carlos O'Donell
2011-12-15 17:48 ` Richard Henderson
2011-12-19 17:45 ` Joseph S. Myers
2011-12-19 18:27 ` Mike Frysinger
2011-12-19 19:57 ` Joseph S. Myers
2012-08-12 5:50 ` [PATCH v2] arm: handle unaligned ABS relocs Mike Frysinger
2012-08-12 13:01 ` Joseph S. Myers
2012-08-12 14:35 ` Mike Frysinger
2012-08-12 15:55 ` Joseph S. Myers
2012-08-12 18:51 ` Mike Frysinger
2012-08-12 13:26 ` Carlos O'Donell
2012-08-12 14:05 ` Andreas Schwab
2012-08-12 15:57 ` Joseph S. Myers
2012-08-14 21:49 ` Roland McGrath
2012-08-15 1:38 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112121920.17908.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).