From: Mike Frysinger <vapier@gentoo.org>
To: Roland McGrath <roland@hack.frob.com>
Cc: libc-ports@sourceware.org, "Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH v2] arm: handle unaligned ABS relocs
Date: Wed, 15 Aug 2012 01:38:00 -0000 [thread overview]
Message-ID: <201208142138.41574.vapier@gentoo.org> (raw)
In-Reply-To: <20120814214846.E13362C0E5@topped-with-meat.com>
[-- Attachment #1: Type: Text/Plain, Size: 1276 bytes --]
On Tuesday 14 August 2012 17:48:46 Roland McGrath wrote:
> > + Elf32_Addr x;
> > + } __attribute__((packed, may_alias));
>
> We put a space between __attribute__ and ((.
committed this:
diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm
index 6775af4..9434a53 100644
--- a/ports/ChangeLog.arm
+++ b/ports/ChangeLog.arm
@@ -1,5 +1,9 @@
2012-08-12 Mike Frysinger <vapier@gentoo.org>
+ * sysdeps/arm/dl-machine.h (elf_machine_rel) [R_ARM_ABS32]: Fix style.
+
+2012-08-12 Mike Frysinger <vapier@gentoo.org>
+
* sysdeps/arm/dl-machine.h (elf_machine_rel) [R_ARM_ABS32]: Declare
a new unaligned struct. Cast reloc_addr to that when updating the
value it points to.
diff --git a/ports/sysdeps/arm/dl-machine.h b/ports/sysdeps/arm/dl-machine.h
index ca66e83..343a83e 100644
--- a/ports/sysdeps/arm/dl-machine.h
+++ b/ports/sysdeps/arm/dl-machine.h
@@ -416,7 +416,7 @@ elf_machine_rel (struct link_map *map, const Elf32_Rel *reloc,
struct unaligned
{
Elf32_Addr x;
- } __attribute__((packed, may_alias));
+ } __attribute__ ((packed, may_alias));
# ifndef RTLD_BOOTSTRAP
/* This is defined in rtld.c, but nowhere in the static
libc.a; make the reference weak so static programs can
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-08-15 1:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 0:20 [patch] handle unaligned arm abs relocs Mike Frysinger
2011-12-14 22:05 ` Carlos O'Donell
2011-12-14 22:29 ` Mike Frysinger
2011-12-14 22:44 ` Carlos O'Donell
2011-12-15 17:48 ` Richard Henderson
2011-12-19 17:45 ` Joseph S. Myers
2011-12-19 18:27 ` Mike Frysinger
2011-12-19 19:57 ` Joseph S. Myers
2012-08-12 5:50 ` [PATCH v2] arm: handle unaligned ABS relocs Mike Frysinger
2012-08-12 13:01 ` Joseph S. Myers
2012-08-12 14:35 ` Mike Frysinger
2012-08-12 15:55 ` Joseph S. Myers
2012-08-12 18:51 ` Mike Frysinger
2012-08-12 13:26 ` Carlos O'Donell
2012-08-12 14:05 ` Andreas Schwab
2012-08-12 15:57 ` Joseph S. Myers
2012-08-14 21:49 ` Roland McGrath
2012-08-15 1:38 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208142138.41574.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).