public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@hack.frob.com>
To: <libc-alpha@sourceware.org>,    <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/off64_t] clean up wordsize-64 off_t functions
Date: Thu, 02 Aug 2012 21:47:00 -0000	[thread overview]
Message-ID: <20120802214648.64D7C2C0AA@topped-with-meat.com> (raw)
In-Reply-To: Joseph S. Myers's message of  Thursday, 2 August 2012 20:46:34 +0000 <Pine.LNX.4.64.1208022043420.28917@digraph.polyomino.org.uk>

I've updated the roland/off64_t branch and I now think it should cover all
wordsize-64 configurations, but only x86_64 has actually been tested.
So folks please test on:
	alpha, ia64, mips64, tilegx64, powerpc64, s390x, sparc64

We don't have much in the way of test coverage for this stuff.
So I would recommend checking that it doesn't change the code at all
rather than just running the test suite.

What I've been doing on x86_64-linux-gnu is:

* Do a complete build from master for the baseline.
* In your build directory do:
$ tar cf save.tar `find . -name '*.so'`
$ mkdir =save; (cd =save; tar xf save.tar)
* Update your build from the branch:
$ push $srcdir; git checkout roland/off64_t; popd
$ rm io/lockf* libio/{fseeko,ftello,iof?etpos}*
$ make -j<n>
(or clean build if you prefer).
* Compare objdump -rd output on the saved files:
$ so=`find =save -type f | sed s,=save/,,`
$ for x in $so; do diff -u <(objdump -rd =save/$x) <(objdump -rd $x) > =save/$x.diff; done
$ find =save -name \*.diff -ls

Every .diff file for no change will have a size around 260 bytes just for
the diff showing the =save/foo vs foo file names.  If a .diff file is
bigger, then look at it to see if there is something significant.  There
can sometimes be pervasive insignificant changes, where the actual code is
the same but only differs in some immediate values that are the line
numbers in __assert_fail calls and things like that.  This is pretty easy
to tell from eyeballing the diff.

When I get good testing reports from two or three of the seven
architectures above, I'll put the changes in and if any of the
others turn out to be broken you can flame me later.


Thanks,
Roland

  parent reply	other threads:[~2012-08-02 21:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 17:21 Roland McGrath
2012-08-02 18:14 ` Chris Metcalf
2012-08-02 20:23   ` Roland McGrath
2012-08-02 20:46 ` Joseph S. Myers
2012-08-02 20:54   ` Roland McGrath
2012-08-02 21:47   ` Roland McGrath [this message]
2012-08-02 21:55     ` [PATCH roland/dirent64] clean up wordsize-64 struct dirent functions Roland McGrath
2012-08-03 20:12       ` Richard Henderson
2012-08-04  8:30       ` David Miller
2012-08-04  9:23         ` Andreas Schwab
2012-08-04  9:26           ` David Miller
2012-08-04 10:37             ` David Miller
2012-08-04 16:14       ` Chris Metcalf
2012-08-03 19:58     ` [PATCH roland/off64_t] clean up wordsize-64 off_t functions Richard Henderson
2012-08-03 20:12       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120802214648.64D7C2C0AA@topped-with-meat.com \
    --to=roland@hack.frob.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).