From: Chris Metcalf <cmetcalf@tilera.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-alpha@sourceware.org>, <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/dirent64] clean up wordsize-64 struct dirent functions
Date: Sat, 04 Aug 2012 16:14:00 -0000 [thread overview]
Message-ID: <501D4A51.1020609@tilera.com> (raw)
In-Reply-To: <20120802215530.93E2E2C0A9@topped-with-meat.com>
On 8/2/2012 5:55 PM, Roland McGrath wrote:
> This patch is on the roland/dirent64 branch, which forks from the
> roland/off64_t branch (the patch won't apply to master). It removes
> from sysdeps/wordsize-64 the various functions using 'struct dirent'
> and 'struct dirent64' where those types are identical.
>
> I added an __INO_T_MATCHES_INO64_T macro to bits/typesizes.h analogous
> to __OFF_T_MATCHES_OFF64_T. Then sysdeps/unix/sysv/linux/bits/dirent.h
> (shared by all machines) defines _DIRENT_MATCHES_DIRENT64 if both
> __OFF_T_MATCHES_OFF64_T and __INO_T_MATCHES_INO64_T are defined, since
> the use of those types is the only difference between dirent and dirent64.
>
> As before, I've tested that no code changed on x86_64-linux-gnu.
> I think it should cover all wordsize-64 configurations, but they should
> be tested:
> alpha, ia64, mips64, tilegx64, powerpc64, s390x, sparc64
Tested ok on tilegx64.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2012-08-04 16:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 17:21 [PATCH roland/off64_t] clean up wordsize-64 off_t functions Roland McGrath
2012-08-02 18:14 ` Chris Metcalf
2012-08-02 20:23 ` Roland McGrath
2012-08-02 20:46 ` Joseph S. Myers
2012-08-02 20:54 ` Roland McGrath
2012-08-02 21:47 ` Roland McGrath
2012-08-02 21:55 ` [PATCH roland/dirent64] clean up wordsize-64 struct dirent functions Roland McGrath
2012-08-03 20:12 ` Richard Henderson
2012-08-04 8:30 ` David Miller
2012-08-04 9:23 ` Andreas Schwab
2012-08-04 9:26 ` David Miller
2012-08-04 10:37 ` David Miller
2012-08-04 16:14 ` Chris Metcalf [this message]
2012-08-03 19:58 ` [PATCH roland/off64_t] clean up wordsize-64 off_t functions Richard Henderson
2012-08-03 20:12 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501D4A51.1020609@tilera.com \
--to=cmetcalf@tilera.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).