* [PATCH] mips: clear condition bit 23 in fpu too
@ 2012-08-27 16:24 Mike Frysinger
2012-08-27 16:34 ` Joseph S. Myers
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2012-08-27 16:24 UTC (permalink / raw)
To: libc-ports; +Cc: Guido Guenther
From: Guido Guenther <agx@sigxcpu.org>
We've been carrying this in Gentoo for quite a long time to fix some test
failures that people hit.
Original message:
> make[4]: *** [/glibc/glibc-package-2.3/mips-linux/obj/math/test-fpucw.out] Error 1
This test fails since the read back fpu control word is 0x80000 instead
of 0x0. I wonder if this patch is correct:
...
which additionally masks out the condition bit 23 - note that the other
condition bits (25-31) are masked out too?
URL: http://sourceware.org/ml/libc-alpha/2002-10/msg00392.html
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2012-08-27 Guido Guenther <agx@sigxcpu.org>
* sysdeps/mips/fpu_control.h (_FPU_RESERVED): Set bit 29.
---
ports/sysdeps/mips/fpu_control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ports/sysdeps/mips/fpu_control.h b/ports/sysdeps/mips/fpu_control.h
index e9c859a..7307d03 100644
--- a/ports/sysdeps/mips/fpu_control.h
+++ b/ports/sysdeps/mips/fpu_control.h
@@ -85,7 +85,7 @@ extern fpu_control_t __fpu_control;
#define _FPU_RC_UP 0x2
#define _FPU_RC_DOWN 0x3
-#define _FPU_RESERVED 0xfe3c0000 /* Reserved bits in cw */
+#define _FPU_RESERVED 0xfebc0000 /* Reserved bits in cw */
/* The fdlibm code requires strict IEEE double precision arithmetic,
--
1.7.9.7
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mips: clear condition bit 23 in fpu too
2012-08-27 16:24 [PATCH] mips: clear condition bit 23 in fpu too Mike Frysinger
@ 2012-08-27 16:34 ` Joseph S. Myers
2012-08-27 16:43 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Joseph S. Myers @ 2012-08-27 16:34 UTC (permalink / raw)
To: Mike Frysinger; +Cc: libc-ports, Guido Guenther
On Mon, 27 Aug 2012, Mike Frysinger wrote:
> 2012-08-27 Guido Guenther <agx@sigxcpu.org>
>
> * sysdeps/mips/fpu_control.h (_FPU_RESERVED): Set bit 29.
OK.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mips: clear condition bit 23 in fpu too
2012-08-27 16:34 ` Joseph S. Myers
@ 2012-08-27 16:43 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2012-08-27 16:43 UTC (permalink / raw)
To: Joseph S. Myers; +Cc: libc-ports, Guido Guenther
[-- Attachment #1: Type: Text/Plain, Size: 304 bytes --]
On Monday 27 August 2012 12:34:18 Joseph S. Myers wrote:
> On Mon, 27 Aug 2012, Mike Frysinger wrote:
> > 2012-08-27 Guido Guenther <agx@sigxcpu.org>
> >
> > * sysdeps/mips/fpu_control.h (_FPU_RESERVED): Set bit 29.
>
> OK.
thanks, that went much quicker than i thought it would :)
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-27 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-27 16:24 [PATCH] mips: clear condition bit 23 in fpu too Mike Frysinger
2012-08-27 16:34 ` Joseph S. Myers
2012-08-27 16:43 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).