public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [COMMITTED PATCH] tile: use atomic op to unlock pthread_spinlock_t
@ 2012-11-06 14:47 Chris Metcalf
  0 siblings, 0 replies; only message in thread
From: Chris Metcalf @ 2012-11-06 14:47 UTC (permalink / raw)
  To: libc-ports

Atomic ops are issued directly from the core, rather than
potentially sitting in the write buffer, so can improve the
performance of other waiters.  In addition, if we didn't end
up pulling a copy of the cache line where the lock is into cache,
by using an atomic op we don't have to acquire the cache line
before we can unlock.
---
 ports/sysdeps/tile/nptl/pthread_spin_unlock.c |   33 +++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 ports/sysdeps/tile/nptl/pthread_spin_unlock.c

diff --git a/ports/sysdeps/tile/nptl/pthread_spin_unlock.c b/ports/sysdeps/tile/nptl/pthread_spin_unlock.c
new file mode 100644
index 0000000..260f6fa
--- /dev/null
+++ b/ports/sysdeps/tile/nptl/pthread_spin_unlock.c
@@ -0,0 +1,33 @@
+/* pthread_spin_unlock -- unlock a spin lock.  Tile version.
+   Copyright (C) 2012 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include "pthreadP.h"
+#include <atomic.h>
+
+int
+pthread_spin_unlock (pthread_spinlock_t *lock)
+{
+#ifdef __tilegx__
+  /* Use exchange() to bypass the write buffer. */
+  atomic_exchange_rel (lock, 0);
+#else
+  atomic_full_barrier ();
+  *lock = 0;
+#endif
+  return 0;
+}
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-06 14:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-06 14:47 [COMMITTED PATCH] tile: use atomic op to unlock pthread_spinlock_t Chris Metcalf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).