From: Roland McGrath <roland@hack.frob.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>, <macro@codesourcery.com>
Subject: Re: Add CFI information for MIPS assembly sources
Date: Fri, 08 Feb 2013 00:08:00 -0000 [thread overview]
Message-ID: <20130208000754.B61082C098@topped-with-meat.com> (raw)
In-Reply-To: Joseph S. Myers's message of Thursday, 7 February 2013 22:52:35 +0000 <Pine.LNX.4.64.1302072250540.17419@digraph.polyomino.org.uk>
> For SETUP_GP64 and RESTORE_GP64, the cfi_* directives are in the
> individual .S files rather than the macro definitions because the
> macros can be used to save the old gp value in either a register or a
> stack slot, and those need different CFI directives, so a single macro
> SETUP_GP64 can't handle both cases and generate CFI at the same time.
It seems much cleaner to define two pairs of macros for the two cases,
so that the macros can contain the CFI details too. Separating the code
from the CFI like you've done will always be error-prone. Using separate
macros is less total text, as well as less duplication of magic numbers.
Thanks,
Roland
next prev parent reply other threads:[~2013-02-08 0:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 22:52 Joseph S. Myers
2013-02-08 0:08 ` Roland McGrath [this message]
2013-02-08 0:42 ` Joseph S. Myers
2013-02-08 0:47 ` Roland McGrath
2013-02-08 1:06 ` Joseph S. Myers
2013-02-08 14:57 ` Maciej W. Rozycki
2013-02-08 16:30 ` Joseph S. Myers
2013-02-08 17:52 ` Maciej W. Rozycki
2013-02-08 21:11 ` Joseph S. Myers
2013-02-11 18:20 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208000754.B61082C098@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).