From: Roland McGrath <roland@hack.frob.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>, <libc-ports@sourceware.org>
Subject: Re: Link extra-libs consistently with libc and ld.so
Date: Tue, 28 May 2013 23:58:00 -0000 [thread overview]
Message-ID: <20130528235846.BA10F2C073@topped-with-meat.com> (raw)
In-Reply-To: Joseph S. Myers's message of Friday, 17 May 2013 23:18:58 +0000 <Pine.LNX.4.64.1305172317400.22690@digraph.polyomino.org.uk>
> 2013-05-17 Joseph Myers <joseph@codesourcery.com>
>
> * Makefile ($(common-objpfx)linkobj/libc.so): Define
> link-libc-deps to empty as target-specific variable.
> * Makerules (link-libc-args): New variable.
> (libc-for-link): Likewise.
> (link-libc-deps): Likewise.
> (lib%.so): Depend in $(link-libc-deps). Link with
> $(link-libc-args).
s/in/on/
> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so) $(objpfx)libnsl.so: \
> + libc-for-link = $(libnsl-libc)
Use two-space indentation for this case.
Otherwise it looks too similar to a target with commands.
The comment should say why it's there, not just what it is.
(The commentary was inadequate before, but this is a good time to improve it.)
> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so): libc-for-link = $(libnss-libc)
Likewise with this comment.
Aside from those tiny cosmetic issues, this looks fine to me.
Thanks,
Roland
prev parent reply other threads:[~2013-05-28 23:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 0:22 Joseph S. Myers
2013-05-10 0:01 ` David Holsgrove
2013-05-14 0:32 ` Joseph S. Myers
2013-05-14 1:12 ` Roland McGrath
2013-05-17 20:24 ` Roland McGrath
2013-05-17 21:36 ` Joseph S. Myers
2013-05-17 21:42 ` Roland McGrath
2013-05-17 22:56 ` Joseph S. Myers
2013-05-17 23:12 ` Roland McGrath
2013-05-17 23:19 ` Joseph S. Myers
2013-05-28 23:58 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528235846.BA10F2C073@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).