* [COMMITED] Fix executable mode.
@ 2013-06-05 22:17 Ondřej Bílka
2013-06-06 11:55 ` Joseph S. Myers
0 siblings, 1 reply; 3+ messages in thread
From: Ondřej Bílka @ 2013-06-05 22:17 UTC (permalink / raw)
To: libc-alpha, libc-ports
Hi,
I found that file posix/transbug.c had executable flag set. A
find -regex ".*[.][ch]\$" -executable
Revealed two more files.
Commited as obvious.
Changelog
* posix/transbug.c: Likewise.
Changelog.microblaze
* ports/sysdeps/microblaze/bits/atomic.h: Remove executable mode.
* ports/sysdeps/unix/sysv/linux/microblaze/sysdep.h: Likewise.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [COMMITED] Fix executable mode.
2013-06-05 22:17 [COMMITED] Fix executable mode Ondřej Bílka
@ 2013-06-06 11:55 ` Joseph S. Myers
2013-06-06 12:14 ` Ondřej Bílka
0 siblings, 1 reply; 3+ messages in thread
From: Joseph S. Myers @ 2013-06-06 11:55 UTC (permalink / raw)
To: Ondřej Bílka; +Cc: libc-alpha, libc-ports
On Thu, 6 Jun 2013, Ondrej Bilka wrote:
> Changelog
> * posix/transbug.c: Likewise.
Incorrect ChangeLog entry. You can't use "Likewise." for the first entry
in a given ChangeLog file like that; it can only be used after a previous
entry that's more specific.
> Changelog.microblaze
> * ports/sysdeps/microblaze/bits/atomic.h: Remove executable mode.
> * ports/sysdeps/unix/sysv/linux/microblaze/sysdep.h: Likewise.
Paths in ChangeLog files are relative to the directory with the ChangeLog
file. These should not include the "ports/" (and NPTL ChangeLog entries
should not have leading "nptl/", etc.).
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [COMMITED] Fix executable mode.
2013-06-06 11:55 ` Joseph S. Myers
@ 2013-06-06 12:14 ` Ondřej Bílka
0 siblings, 0 replies; 3+ messages in thread
From: Ondřej Bílka @ 2013-06-06 12:14 UTC (permalink / raw)
To: Joseph S. Myers; +Cc: libc-alpha, libc-ports
On Thu, Jun 06, 2013 at 11:55:26AM +0000, Joseph S. Myers wrote:
> On Thu, 6 Jun 2013, Ondrej Bilka wrote:
>
> > Changelog
> > * posix/transbug.c: Likewise.
>
> Incorrect ChangeLog entry. You can't use "Likewise." for the first entry
> in a given ChangeLog file like that; it can only be used after a previous
> entry that's more specific.
>
> > Changelog.microblaze
> > * ports/sysdeps/microblaze/bits/atomic.h: Remove executable mode.
> > * ports/sysdeps/unix/sysv/linux/microblaze/sysdep.h: Likewise.
>
> Paths in ChangeLog files are relative to the directory with the ChangeLog
> file. These should not include the "ports/" (and NPTL ChangeLog entries
> should not have leading "nptl/", etc.).
>
Thanks, fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-06 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 22:17 [COMMITED] Fix executable mode Ondřej Bílka
2013-06-06 11:55 ` Joseph S. Myers
2013-06-06 12:14 ` Ondřej Bílka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).