From: Tom de Vries <Tom_deVries@mentor.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: Maxim Kuvyrkov <maxim@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
GLIBC Devel <libc-alpha@sourceware.org>,
<libc-ports@sourceware.org>,
Tom de Vries <vries@codesourcery.com>
Subject: Re: [PATCH] Optimize libc_lock_lock for MIPS XLP.
Date: Fri, 06 Jul 2012 19:42:00 -0000 [thread overview]
Message-ID: <4FF73F75.6060303@mentor.com> (raw)
In-Reply-To: <4FEC94AF.40301@tilera.com>
On 28/06/12 19:30, Chris Metcalf wrote:
> On 6/27/2012 5:45 PM, Maxim Kuvyrkov wrote:
>> On 15/06/2012, at 2:49 PM, Maxim Kuvyrkov wrote:
>>
>>>> On 15/06/2012, at 2:44 PM, Chris Metcalf wrote:
>>>>
>>>>>> On 6/14/2012 9:20 PM, Maxim Kuvyrkov wrote:
>>>> ...
>>>>>>>> As I read it, in case of a contended lock __lll_lock_wait will reset the value of the lock to "2" before calling lll_futex_wait(). I agree that there is a timing window in which the other threads will see a value of the lock greater than "2", but the value will not get as high as hundreds or billions as it will be constantly reset to "2" in atomic_exchange in lll_lock_wait().
>>>>>>>>
>>>>>>>> I do not see how threads will get into a busywait state, though. Would you please elaborate on that?
>>>>>>
>>>>>> You are correct. I was thinking the that the while loop had a cmpxchg, but
>>>>>> since it's just a straight-up exchange, the flow will be something like:
>>>>>>
>>>>>> - Fail to initially call lll_futex_wait() if the lock is contended
>>>>>> - Fall through to while loop
>>>>>> - Spin as long as the lock is contended enough that *futex > 2
>>>>>> - Enter futex_wait
>>>>>>
>>>>>> So a little busy under high contention, but probably settles out reasonably
>>>>>> well.
>>>>
>> Attached is an improved patch that also optimizes __libc_lock_trylock using XLP's atomic instructions.
>>
>> The patch also removes unnecessary indirection step represented by new macros lll_add_lock, which is then used to define __libc_lock_lock, and defines __libc_lock_lock and __libc_lock_trylock directly in lowlevellock.h . This makes changes outside of ports/ trivial.
>>
>> Tested on MIPS XLP with no regressions. OK to apply for 2.17?
>
> It looks OK to me. I would want someone else to sign off on it before
> applying to 2.17.
>
Chris,
I cannot sign off on this, but I reviewed the current patch as well and it looks
ok to me too.
Thanks,
- Tom
next prev parent reply other threads:[~2012-07-06 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 5:04 Maxim Kuvyrkov
2012-06-14 12:39 ` Chris Metcalf
2012-06-15 1:21 ` Maxim Kuvyrkov
2012-06-15 2:44 ` Chris Metcalf
2012-06-15 2:50 ` Maxim Kuvyrkov
2012-06-27 21:45 ` Maxim Kuvyrkov
2012-06-28 17:30 ` Chris Metcalf
2012-07-06 19:42 ` Tom de Vries [this message]
2012-08-14 4:00 ` Maxim Kuvyrkov
2012-08-14 19:33 ` Chris Metcalf
2012-08-14 21:30 ` Maxim Kuvyrkov
2012-08-14 21:40 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF73F75.6060303@mentor.com \
--to=tom_devries@mentor.com \
--cc=cmetcalf@tilera.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=maxim@codesourcery.com \
--cc=vries@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).