From: Chris Metcalf <cmetcalf@tilera.com>
To: Maxim Kuvyrkov <maxim@codesourcery.com>
Cc: Tom de Vries <Tom_deVries@mentor.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
GLIBC Devel <libc-alpha@sourceware.org>,
<libc-ports@sourceware.org>,
Tom de Vries <vries@codesourcery.com>
Subject: Re: [PATCH] Optimize libc_lock_lock for MIPS XLP.
Date: Tue, 14 Aug 2012 19:33:00 -0000 [thread overview]
Message-ID: <502AA7EC.5020406@tilera.com> (raw)
In-Reply-To: <7CC74175-BA9B-4461-8918-9D99DABEC484@codesourcery.com>
On 8/14/2012 12:00 AM, Maxim Kuvyrkov wrote:
> + atomic_compared_and_exchange_acq take the same time to execute.
Typo.
> + if (__result >= 2) \
> + __result = (atomic_exchange_acq (__futex, 2) != 0); \
Why not just return the old value in memory here (i.e. omit the "!= 0"), as
you do with the exchange_and_add above? That seems more parallel in
structure, and also more efficient.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2012-08-14 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 5:04 Maxim Kuvyrkov
2012-06-14 12:39 ` Chris Metcalf
2012-06-15 1:21 ` Maxim Kuvyrkov
2012-06-15 2:44 ` Chris Metcalf
2012-06-15 2:50 ` Maxim Kuvyrkov
2012-06-27 21:45 ` Maxim Kuvyrkov
2012-06-28 17:30 ` Chris Metcalf
2012-07-06 19:42 ` Tom de Vries
2012-08-14 4:00 ` Maxim Kuvyrkov
2012-08-14 19:33 ` Chris Metcalf [this message]
2012-08-14 21:30 ` Maxim Kuvyrkov
2012-08-14 21:40 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502AA7EC.5020406@tilera.com \
--to=cmetcalf@tilera.com \
--cc=Tom_deVries@mentor.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=maxim@codesourcery.com \
--cc=vries@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).