public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: Marek Polacek <polacek@redhat.com>
Cc: <libc-alpha@sourceware.org>, libc-ports <libc-ports@sourceware.org>
Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}
Date: Thu, 02 Aug 2012 19:49:00 -0000	[thread overview]
Message-ID: <501AD9BB.5020809@tilera.com> (raw)
In-Reply-To: <20120802190710.GG3310@redhat.com>

On 8/2/2012 3:07 PM, Marek Polacek wrote:
> I've pushed this now.  Hope it won't break anything.

Thanks for the heads-up.  I fixed tile.

commit 2fbd74d8c906ec303866101a5026f4ca098ef58e
Author: Chris Metcalf <cmetcalf@tilera.com>
Date:   Thu Aug 2 15:48:14 2012 -0400

    tile: Get rid of ASM_TYPE_DIRECTIVE

diff --git a/ports/ChangeLog.tile b/ports/ChangeLog.tile
index 471cf12..05f08bd 100644
--- a/ports/ChangeLog.tile
+++ b/ports/ChangeLog.tile
@@ -1,3 +1,7 @@
+2012-08-02  Chris Metcalf  <cmetcalf@tilera.com>
+
+       * sysdeps/tile/sysdep.h: Do not define ASM_TYPE_DIRECTIVE.
+
 2012-08-01  Joseph Myers  <joseph@codesourcery.com>

        * sysdeps/unix/sysv/linux/tile/kernel-features.h
diff --git a/ports/sysdeps/tile/sysdep.h b/ports/sysdeps/tile/sysdep.h
index 34d7046..a268872 100644
--- a/ports/sysdeps/tile/sysdep.h
+++ b/ports/sysdeps/tile/sysdep.h
@@ -24,14 +24,13 @@

 #include <feedback.h>

-/* Make use of .type and .size directives.  */
-#define ASM_TYPE_DIRECTIVE(name,typearg) .type name,typearg;
+/* Make use of .size directive.  */
 #define ASM_SIZE_DIRECTIVE(name) .size name,.-name;

 /* Define an entry point visible from C.  */
 #define        ENTRY(name)                                                           \
   .globl C_SYMBOL_NAME(name);                                                \
-  ASM_TYPE_DIRECTIVE (C_SYMBOL_NAME(name),@function)                         \
+  .type C_SYMBOL_NAME(name),@function                                        \
   .align 8;                                                                  \
   C_LABEL(name)                                                                      \
   cfi_startproc;                                                             \

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

  reply	other threads:[~2012-08-02 19:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 19:20 Marek Polacek
2012-07-27 20:28 ` Roland McGrath
2012-07-27 20:58   ` Carlos O'Donell
2012-07-27 22:12   ` Marek Polacek
2012-07-28  1:10 ` Kaz Kojima
2012-08-02 19:07 ` Marek Polacek
2012-08-02 19:49   ` Chris Metcalf [this message]
2012-08-02 20:59   ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501AD9BB.5020809@tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).