public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: libc-ports <libc-ports@sourceware.org>
Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}
Date: Thu, 02 Aug 2012 20:59:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1208022058380.28917@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20120802190710.GG3310@redhat.com>

I've applied this patch to remove it for ARM.  am33, ia64 and m68k remain 
to be updated.

diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm
index 58ad60d..8379dc0 100644
--- a/ports/ChangeLog.arm
+++ b/ports/ChangeLog.arm
@@ -1,3 +1,8 @@
+2012-08-02  Joseph Myers  <joseph@codesourcery.com>
+
+	* sysdeps/arm/sysdep.h (ASM_TYPE_DIRECTIVE): Remove.
+	(ENTRY): Do not use ASM_TYPE_DIRECTIVE.
+
 2012-08-01  Joseph Myers  <joseph@codesourcery.com>
 
 	* sysdeps/unix/sysv/linux/arm/kernel-features.h
diff --git a/ports/sysdeps/arm/sysdep.h b/ports/sysdeps/arm/sysdep.h
index cd3d70b..6ec2bd6 100644
--- a/ports/sysdeps/arm/sysdep.h
+++ b/ports/sysdeps/arm/sysdep.h
@@ -30,8 +30,6 @@
 /* Syntactic details of assembler.  */
 
 #define ALIGNARG(log2) log2
-/* For ELF we need the `.type' directive to make shared libs work right.  */
-#define ASM_TYPE_DIRECTIVE(name,typearg) .type name,%##typearg;
 #define ASM_SIZE_DIRECTIVE(name) .size name,.-name
 
 #define PLTJMP(_x)	_x##(PLT)
@@ -63,7 +61,7 @@
 /* Define an entry point visible from C.  */
 #define	ENTRY(name)							      \
   .globl C_SYMBOL_NAME(name);						      \
-  ASM_TYPE_DIRECTIVE (C_SYMBOL_NAME(name),function)			      \
+  .type C_SYMBOL_NAME(name),%function;					      \
   .align ALIGNARG(4);							      \
   C_LABEL(name)								      \
   .cfi_sections .debug_frame;						      \

-- 
Joseph S. Myers
joseph@codesourcery.com

      parent reply	other threads:[~2012-08-02 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 19:20 Marek Polacek
2012-07-27 20:28 ` Roland McGrath
2012-07-27 20:58   ` Carlos O'Donell
2012-07-27 22:12   ` Marek Polacek
2012-07-28  1:10 ` Kaz Kojima
2012-08-02 19:07 ` Marek Polacek
2012-08-02 19:49   ` Chris Metcalf
2012-08-02 20:59   ` Joseph S. Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1208022058380.28917@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).