public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [COMMITTED] alpha: Fix redefinition of __isnanl macro warning
@ 2012-12-07 19:07 Richard Henderson
  2012-12-07 19:10 ` Roland McGrath
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2012-12-07 19:07 UTC (permalink / raw)
  To: libc-ports

In bdd7898a58bd76ac3b411a4931ff3f9e77eabe6a we added self-definitions
of __isnan and friends in order to indicate specialized architecture
support, and avoid redefinitions within various generic math_private.h.

There is no generic math_private.h that concerns ldbl-128, and while
we provide __isnanl in the alpha math_private.h there's no need to
protect the function against redefinition.
---
 ports/ChangeLog.alpha | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ports/ChangeLog.alpha b/ports/ChangeLog.alpha
index 21a4f12..9be0600 100644
--- a/ports/ChangeLog.alpha
+++ b/ports/ChangeLog.alpha
@@ -3,6 +3,8 @@
 	* sysdeps/alpha/Makefile [$(subdir) = math]
 	(CFLAGS-s_isnan.c): New variable.
 
+	* sysdeps/alpha/fpu/math_private.h (__isnanl): Remove definition.
+
 2012-11-30  Richard Henderson  <rth@redhat.com>
 
 	* sysdeps/alpha/fpu/libm-test-ulps: Update.
-- 
1.7.11.7

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [COMMITTED] alpha: Fix redefinition of __isnanl macro warning
  2012-12-07 19:07 [COMMITTED] alpha: Fix redefinition of __isnanl macro warning Richard Henderson
@ 2012-12-07 19:10 ` Roland McGrath
  2012-12-07 19:24   ` Richard Henderson
  0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2012-12-07 19:10 UTC (permalink / raw)
  To: Richard Henderson; +Cc: libc-ports

The change you actually sent was ChangeLog.alpha only.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [COMMITTED] alpha: Fix redefinition of __isnanl macro warning
  2012-12-07 19:10 ` Roland McGrath
@ 2012-12-07 19:24   ` Richard Henderson
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2012-12-07 19:24 UTC (permalink / raw)
  To: Roland McGrath; +Cc: libc-ports

On 2012-12-07 13:10, Roland McGrath wrote:
> The change you actually sent was ChangeLog.alpha only.
> 

Argh!  I've committed the rest of the patch now too.
For the record, here's the composite diff:


r~


diff --git a/ports/ChangeLog.alpha b/ports/ChangeLog.alpha
index 21a4f12..9be0600 100644
--- a/ports/ChangeLog.alpha
+++ b/ports/ChangeLog.alpha
@@ -3,6 +3,8 @@
 	* sysdeps/alpha/Makefile [$(subdir) = math]
 	(CFLAGS-s_isnan.c): New variable.
 
+	* sysdeps/alpha/fpu/math_private.h (__isnanl): Remove definition.
+
 2012-11-30  Richard Henderson  <rth@redhat.com>
 
 	* sysdeps/alpha/fpu/libm-test-ulps: Update.
diff --git a/ports/sysdeps/alpha/fpu/math_private.h b/ports/sysdeps/alpha/fpu/math_private.h
index 4f270f7..22ab3b9 100644
--- a/ports/sysdeps/alpha/fpu/math_private.h
+++ b/ports/sysdeps/alpha/fpu/math_private.h
@@ -12,9 +12,6 @@
 #ifndef __isnanf
 # define __isnanf __isnanf
 #endif
-#ifndef __isnanl
-# define __isnanl __isnanl
-#endif
 
 #include_next <math_private.h>
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-07 19:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-07 19:07 [COMMITTED] alpha: Fix redefinition of __isnanl macro warning Richard Henderson
2012-12-07 19:10 ` Roland McGrath
2012-12-07 19:24   ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).