From: "Carlos O'Donell" <carlos@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Chris Metcalf <cmetcalf@tilera.com>,
Roland McGrath <roland@hack.frob.com>,
libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: [PATCH] Don't build .os objects of static-only-routines for extra libs
Date: Tue, 12 Mar 2013 14:06:00 -0000 [thread overview]
Message-ID: <513F364D.1080703@redhat.com> (raw)
In-Reply-To: <mvmtxohnfgu.fsf_-_@hawking.suse.de>
On 03/12/2013 05:18 AM, Andreas Schwab wrote:
> * extra-lib.mk (extra-objs): Add static-only-routines as .oS
> instead of .os.
> ---
> extra-lib.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/extra-lib.mk b/extra-lib.mk
> index a2293c5..247946f 100644
> --- a/extra-lib.mk
> +++ b/extra-lib.mk
> @@ -34,7 +34,12 @@ extra-objs += $(foreach o,$(filter-out .os .oS,$(object-suffixes-$(lib))),\
> $($(lib)-shared-only-routines),\
> $(all-$(lib)-routines))))
> ifneq (,$(filter .os,$(object-suffixes-$(lib))))
> -extra-objs += $(all-$(lib)-routines:%=%.os)
> +extra-objs += $(patsubst %,%.os,$(filter-out $($(lib)-static-only-routines),\
> + $(all-$(lib)-routines)))
> +endif
> +ifneq (,$(filter .oS,$(object-suffixes-$(lib))))
> +extra-objs += $(patsubst %,%.oS,$(filter $($(lib)-static-only-routines),\
> + $(all-$(lib)-routines)))
> endif
> alltypes-$(lib) := $(foreach o,$(object-suffixes-$(lib)),\
> $(objpfx)$(patsubst %,$(libtype$o),\
>
Does this actually cause a problem building a library
using extra-lib.mk?
I'm trying to read the code and determine under which
conditions this would break one of the existing libraries
we build uding extra-lib.mk, but given my build logs it
looks like
I understand that this is a correctness issue, but I was
just wondering if it has any actual impact on our builds
today.
Cheers,
Carlos.
next prev parent reply other threads:[~2013-03-12 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mvmr4juw5y8.fsf@hawking.suse.de>
[not found] ` <20130308215906.6B7A22C0A5@topped-with-meat.com>
2013-03-11 9:46 ` Fix SHLIB_COMPAT with undefined obsoleting version Andreas Schwab
2013-03-11 13:09 ` Chris Metcalf
2013-03-11 13:36 ` Andreas Schwab
2013-03-11 14:17 ` Chris Metcalf
2013-03-11 14:38 ` Andreas Schwab
2013-03-12 9:18 ` [PATCH] Don't build .os objects of static-only-routines for extra libs Andreas Schwab
2013-03-12 14:06 ` Carlos O'Donell [this message]
2013-03-12 15:40 ` Andreas Schwab
2013-03-12 22:24 ` Carlos O'Donell
2013-03-12 14:23 ` Chris Metcalf
2013-03-12 17:38 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F364D.1080703@redhat.com \
--to=carlos@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).