From: Andreas Jaeger <aj@suse.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: [PATCH][BZ #15465] Avoid crashing with LD_DEBUG=symbols when program name is unavailable
Date: Tue, 14 May 2013 13:35:00 -0000 [thread overview]
Message-ID: <51923D97.9010703@suse.com> (raw)
In-Reply-To: <20130514103124.GN25336@spoyarek.pnq.redhat.com>
On 05/14/2013 12:31 PM, Siddhesh Poyarekar wrote:
> Hi,
>
> The program name may be unavailable if the user application tampers
> with argc and argv[]. Some parts of the dynamic linker check this
> while others don't, so this patch consolidates the check and fallback
> into a single macro and updates all users. I have also added a simple
> test to verify the fix and have also verified that this does not
> result in any regressions in the testsuite.
>
> I have made mechanical changes to architectures other than x86 (even
> in ports), that I haven't tested. Could the maintainers test and give
> feedback?
Wow, the checking was really inconsistent throughout the code. I
reviewed the changes and they look fine to me,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
next prev parent reply other threads:[~2013-05-14 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 10:29 Siddhesh Poyarekar
2013-05-14 13:35 ` Andreas Jaeger [this message]
2013-05-21 7:16 ` [all-arch-ping][BZ " Siddhesh Poyarekar
2013-05-29 4:02 ` Carlos O'Donell
2013-05-29 16:06 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51923D97.9010703@suse.com \
--to=aj@suse.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).