public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Allan McRae <allan@archlinux.org>
To: "Ondřej Bílka" <neleai@seznam.cz>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
	 libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: [PATCH 1/9] Fix typos.
Date: Sun, 18 Aug 2013 22:31:00 -0000	[thread overview]
Message-ID: <52114B22.3090902@archlinux.org> (raw)
In-Reply-To: <20130818220954.GA20381@domone>

On 19/08/13 08:09, Ondřej Bílka wrote:
> On Sun, Aug 18, 2013 at 08:15:24PM +0000, Joseph S. Myers wrote:
>> I stopped commenting here.  For any subsequent revisions, in addition to 
>> the points I identified above, please keep patches down to at most 1000 
>> lines for convenience of review, and wait until consensus has been reached 
>> on a single posted patch before sending any subsequent patches (also of at 
>> most 1000 lines).
>>
> I split patches to 1000 lines, here is first one.
> 

<snip>

This is the only one that I think needs fixed as there was more than
just a typo going on there.

> diff --git a/iconv/skeleton.c b/iconv/skeleton.c
> index 45beb06..6997e05 100644
> --- a/iconv/skeleton.c
> +++ b/iconv/skeleton.c
> @@ -514,7 +514,7 @@ FUNCTION_NAME (struct __gconv_step *step, struct __gconv_step_data *data,
>        size_t *lirreversiblep = irreversible ? &lirreversible : NULL;
>  
>        /* The following assumes that encodings, which have a variable length
> -	 what might unalign a buffer even though it is a aligned in the
> +	 what might unalign a buffer even though it is an aligned in the
>  	 beginning, either don't have the minimal number of bytes as a divisor
>  	 of the maximum length or have a minimum length of 1.  This is true
>  	 for all known and supported encodings.


  reply	other threads:[~2013-08-18 22:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13  8:27 [PATCH] " Ondřej Bílka
2013-08-14 19:18 ` Roland McGrath
2013-08-18 16:50 ` Ondřej Bílka
2013-08-18 20:15   ` Joseph S. Myers
2013-08-18 22:10     ` [PATCH 1/9] " Ondřej Bílka
2013-08-18 22:31       ` Allan McRae [this message]
2013-08-19 19:32       ` Joseph S. Myers
2013-08-21 10:38         ` [PATCH 1/9 v2] " Ondřej Bílka
2013-08-21 15:48           ` Joseph S. Myers
2013-08-22 13:56       ` [PATCH 2/9] " Ondřej Bílka
2013-08-22 15:04         ` Joseph S. Myers
2013-08-24  7:43           ` Ondřej Bílka
2013-08-28 16:07             ` Joseph S. Myers
2013-08-30 10:48       ` [PATCH 3/9] " Ondřej Bílka
2013-08-30 11:01         ` Will Newton
2013-08-30 15:47           ` [PATCH 3/9 v2] " Ondřej Bílka
2013-08-30 16:01             ` Joseph S. Myers
2013-08-30 12:58       ` [PATCH 3.5/9] Fix then/than typo Ondřej Bílka
2013-08-30 13:34         ` Allan McRae
2013-08-30 16:22         ` Brooks Moses
2013-09-02  9:30           ` [COMMITED] Fix additional typo Ondřej Bílka
2013-09-02  9:37       ` [PATCH 4/9] Fix typos Ondřej Bílka
2013-09-02 10:01         ` Florian Weimer
2013-09-02 10:15         ` Allan McRae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52114B22.3090902@archlinux.org \
    --to=allan@archlinux.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=neleai@seznam.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).