public inbox for
 help / color / mirror / Atom feed
From: "Carlos O'Donell" <>
To: Will Newton <>
Cc: "Joseph S. Myers" <>,
	       "" <>,
	       Patch Tracking <>
Subject: Re: [PATCH] sysdeps/arm/armv6t2/strlen.S: strlen implementation for armv6t2.
Date: Fri, 30 Aug 2013 17:38:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 08/30/2013 01:36 PM, Carlos O'Donell wrote:
> On 08/30/2013 05:06 AM, Will Newton wrote:
>> On 30 August 2013 01:13, Joseph S. Myers <> wrote:
>>> On Mon, 12 Aug 2013, Will Newton wrote:
>>>> This implementation of strlen is faster than the armv6 version for
>>>> all string lengths greater than 1 on a Cortex-A15.
>>>> ports/ChangeLog.arm:
>>>> 2013-08-09  Will Newton  <>
>>>>       * sysdeps/arm/armv6t2/strlen.S: New file.
>>> OK, presuming you've run the full glibc testsuite with this version used.
>> Yes, testsuite is clean. Committed.
> I'm not happy seeing these kinds of patches go in without some
> kind of numbers around "faster" and a reproducible way to get
> those numbers.

I don't say this because I'm just cranky, I want all of us to be
more accountable when it comes to the engineering rigour required
for performance patches. That way I can look back at these numbers
when users report issues with the speed of strlen on A15.


      reply	other threads:[~2013-08-30 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12  7:56 Will Newton
2013-08-27  7:47 ` Will Newton
2013-08-30  0:13 ` Joseph S. Myers
2013-08-30  9:06   ` Will Newton
2013-08-30 17:36     ` Carlos O'Donell
2013-08-30 17:38       ` Carlos O'Donell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).