From: "Carlos O'Donell" <carlos@redhat.com>
To: Will Newton <will.newton@linaro.org>, libc-ports@sourceware.org
Cc: patches@linaro.org
Subject: Re: [PATCH] ARM: Fix clone build for ARMv4
Date: Thu, 23 Jan 2014 17:31:00 -0000 [thread overview]
Message-ID: <52E151CE.20103@redhat.com> (raw)
In-Reply-To: <1390477771-30826-1-git-send-email-will.newton@linaro.org>
On 01/23/2014 06:49 AM, Will Newton wrote:
> ARMv4 does not have the blx instruction, so use the BLX macro which
> handles abstracting this for us.
>
> ports/ChangeLog.arm:
>
> 2014-01-23 Will Newton <will.newton@linaro.org>
>
> [BZ #16499]
> * sysdeps/unix/sysv/linux/arm/clone.S: Use BLX macro instead
> of blx instruction directly.
> ---
> ports/sysdeps/unix/sysv/linux/arm/clone.S | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/ports/sysdeps/unix/sysv/linux/arm/clone.S b/ports/sysdeps/unix/sysv/linux/arm/clone.S
> index 44286a5..03fe9ab 100644
> --- a/ports/sysdeps/unix/sysv/linux/arm/clone.S
> +++ b/ports/sysdeps/unix/sysv/linux/arm/clone.S
> @@ -88,14 +88,8 @@ PSEUDO_END (__clone)
> #endif
> @ pick the function arg and call address off the stack and execute
> ldr r0, [sp, #4]
> -#if defined(__ARM_ARCH_4T__) && defined(__THUMB_INTERWORK__)
> ldr ip, [sp], #8
> - mov lr, pc
> - bx ip
> -#else
> - ldr lr, [sp], #8
> - blx lr
> -#endif
> + BLX (ip)
Looks good.
>
> @ and we are done, passing the return value through r0
> b PLTJMP(HIDDEN_JUMPTARGET(_exit))
>
Did you test this or ask the submitter to test it?
If he says it works then OK to commit.
Cheers,
Carlos.
next prev parent reply other threads:[~2014-01-23 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 11:49 Will Newton
2014-01-23 16:32 ` Joseph S. Myers
2014-01-23 17:31 ` Carlos O'Donell [this message]
2014-01-23 18:22 ` Will Newton
2014-01-24 13:17 ` Will Newton
2014-01-25 10:10 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E151CE.20103@redhat.com \
--to=carlos@redhat.com \
--cc=libc-ports@sourceware.org \
--cc=patches@linaro.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).