public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] AArch64 Indent pre-processor directives.
@ 2012-11-20 12:18 Marcus Shawcroft
  2012-11-20 19:28 ` Thomas Schwinge
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Shawcroft @ 2012-11-20 12:18 UTC (permalink / raw)
  To: libc-ports; +Cc: Andreas Jaeger

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

This patch indents the pre-processor directives introduced by this patch:

http://sourceware.org/ml/libc-ports/2012-11/msg00060.html

and addresses one of the comments raised by Andreas here:

http://sourceware.org/ml/libc-ports/2012-11/msg00066.html

/Marcus

2012-11-20  Marcus Shawcroft  <marcus.shawcroft@linaro.org>

        * sysdeps/aarch64/fpu/s_fma.c: Indent preprocessor directives.
        * sysdeps/aarch64/fpu/s_fmin.c: Likewise.
        * sysdeps/aarch64/fpu/s_frint.c: Likewise.
        * sysdeps/aarch64/fpu/s_frintf.c: Likewise.
        * sysdeps/aarch64/fpu/s_lrint.c: Likewise.
        * sysdeps/aarch64/fpu/s_lround.c: Likewise.

[-- Attachment #2: 0004-Indent-preprocessor-directives.patch --]
[-- Type: application/octet-stream, Size: 3431 bytes --]

diff --git a/ports/sysdeps/aarch64/fpu/s_fma.c b/ports/sysdeps/aarch64/fpu/s_fma.c
index 7dc7073..62b0642 100644
--- a/ports/sysdeps/aarch64/fpu/s_fma.c
+++ b/ports/sysdeps/aarch64/fpu/s_fma.c
@@ -19,16 +19,16 @@
 #include <math.h>
 
 #ifndef FUNC
-#define FUNC fma
+# define FUNC fma
 #endif
 
 #ifndef TYPE
-#define TYPE double
-#define REGS "d"
+# define TYPE double
+# define REGS "d"
 #else
-#ifndef REGS
-#error REGS not defined
-#endif
+# ifndef REGS
+#  error REGS not defined
+# endif
 #endif
 
 #define __CONCATX(a,b) __CONCAT(a,b)
diff --git a/ports/sysdeps/aarch64/fpu/s_fmin.c b/ports/sysdeps/aarch64/fpu/s_fmin.c
index 796e4e4..d107133 100644
--- a/ports/sysdeps/aarch64/fpu/s_fmin.c
+++ b/ports/sysdeps/aarch64/fpu/s_fmin.c
@@ -19,20 +19,20 @@
 #include <math.h>
 
 #ifndef FUNC
-#define FUNC fmin
+# define FUNC fmin
 #endif
 
 #ifndef INSN
-#define INSN "fminnm"
+# define INSN "fminnm"
 #endif
 
 #ifndef TYPE
-#define TYPE double
-#define REGS "d"
+# define TYPE double
+# define REGS "d"
 #else
-#ifndef REGS
-#error REGS not defined
-#endif
+# ifndef REGS
+#  error REGS not defined
+# endif
 #endif
 
 #define __CONCATX(a,b) __CONCAT(a,b)
diff --git a/ports/sysdeps/aarch64/fpu/s_frint.c b/ports/sysdeps/aarch64/fpu/s_frint.c
index 2a54cdf..af4a23c 100644
--- a/ports/sysdeps/aarch64/fpu/s_frint.c
+++ b/ports/sysdeps/aarch64/fpu/s_frint.c
@@ -19,20 +19,20 @@
 #include <math.h>
 
 #ifndef FUNC
-#error FUNC not defined
+# error FUNC not defined
 #endif
 
 #ifndef TYPE
-#define TYPE double
-#define REGS "d"
+# define TYPE double
+# define REGS "d"
 #else
-#ifndef REGS
-#error REGS not defined
-#endif
+# ifndef REGS
+#  error REGS not defined
+# endif
 #endif
 
 #ifndef INSN
-#error INSN not defined
+# error INSN not defined
 #endif
 
 #define __CONCATX(a,b) __CONCAT(a,b)
diff --git a/ports/sysdeps/aarch64/fpu/s_frintf.c b/ports/sysdeps/aarch64/fpu/s_frintf.c
index 1fbe838..8d24dda 100644
--- a/ports/sysdeps/aarch64/fpu/s_frintf.c
+++ b/ports/sysdeps/aarch64/fpu/s_frintf.c
@@ -17,7 +17,7 @@
    <http://www.gnu.org/licenses/>.  */
 
 #ifndef FUNC
-#error FUNC not defined
+# error FUNC not defined
 #endif
 #define TYPE float
 #define REGS "s"
diff --git a/ports/sysdeps/aarch64/fpu/s_lrint.c b/ports/sysdeps/aarch64/fpu/s_lrint.c
index ccce636..cf62753 100644
--- a/ports/sysdeps/aarch64/fpu/s_lrint.c
+++ b/ports/sysdeps/aarch64/fpu/s_lrint.c
@@ -19,20 +19,20 @@
 #include <math.h>
 
 #ifndef FUNC
-#define FUNC lrint
+# define FUNC lrint
 #endif
 
 #ifndef ITYPE
-#define ITYPE double
-#define IREGS "d"
+# define ITYPE double
+# define IREGS "d"
 #else
-#ifndef IREGS
-#error IREGS not defined
-#endif
+# ifndef IREGS
+#  error IREGS not defined
+# endif
 #endif
 
 #ifndef OTYPE
-#define OTYPE long int
+# define OTYPE long int
 #endif
 
 #define OREGS "x"
diff --git a/ports/sysdeps/aarch64/fpu/s_lround.c b/ports/sysdeps/aarch64/fpu/s_lround.c
index b400caa..f3bb6cf 100644
--- a/ports/sysdeps/aarch64/fpu/s_lround.c
+++ b/ports/sysdeps/aarch64/fpu/s_lround.c
@@ -19,20 +19,20 @@
 #include <math.h>
 
 #ifndef FUNC
-#define FUNC lround
+# define FUNC lround
 #endif
 
 #ifndef ITYPE
-#define ITYPE double
-#define IREGS "d"
+# define ITYPE double
+# define IREGS "d"
 #else
-#ifndef IREGS
-#error IREGS not defined
-#endif
+# ifndef IREGS
+#  error IREGS not defined
+# endif
 #endif
 
 #ifndef OTYPE
-#define OTYPE long int
+# define OTYPE long int
 #endif
 
 #define OREGS "x"
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] AArch64 Indent pre-processor directives.
  2012-11-20 12:18 [PATCH] AArch64 Indent pre-processor directives Marcus Shawcroft
@ 2012-11-20 19:28 ` Thomas Schwinge
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Schwinge @ 2012-11-20 19:28 UTC (permalink / raw)
  To: Marcus Shawcroft; +Cc: Andreas Jaeger, libc-ports

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Hi!

On Tue, 20 Nov 2012 12:18:19 +0000, Marcus Shawcroft <marcus.shawcroft@linaro.org> wrote:
> This patch indents the pre-processor directives introduced by this patch:
> 
> http://sourceware.org/ml/libc-ports/2012-11/msg00060.html
> 
> and addresses one of the comments raised by Andreas here:
> 
> http://sourceware.org/ml/libc-ports/2012-11/msg00066.html
> 
> /Marcus
> 
> 2012-11-20  Marcus Shawcroft  <marcus.shawcroft@linaro.org>
> 
>         * sysdeps/aarch64/fpu/s_fma.c: Indent preprocessor directives.
>         * sysdeps/aarch64/fpu/s_fmin.c: Likewise.
>         * sysdeps/aarch64/fpu/s_frint.c: Likewise.
>         * sysdeps/aarch64/fpu/s_frintf.c: Likewise.
>         * sysdeps/aarch64/fpu/s_lrint.c: Likewise.
>         * sysdeps/aarch64/fpu/s_lround.c: Likewise.

Looks good to me, though I have not checked whether there are any further
instances where the indentation should be changed.


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-20 19:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-20 12:18 [PATCH] AArch64 Indent pre-processor directives Marcus Shawcroft
2012-11-20 19:28 ` Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).