* [PATCH 2/2] glibc: Define HAVE_ARM_PCS_VFP
@ 2012-05-07 2:22 Carlos O'Donell
2012-05-07 20:05 ` Roland McGrath
0 siblings, 1 reply; 3+ messages in thread
From: Carlos O'Donell @ 2012-05-07 2:22 UTC (permalink / raw)
To: GNU C Library, Joseph S. Myers; +Cc: libc-ports, Khem Raj
This final patch adds a config.h.in definition that will be set by the
ARM configure fragment when the hard-float ABI is detected.
The ARM shlib-versions file will use an %ifdef HAVE_ARM_PCS_VFP to
select the appropriate dynamic linker.
It was noted by Joseph Myers that it not a very good design to have
x86/x86_64, SPARC, Power, and now ARM defines in the top-level
config.in.h. We really should cleanup the config.in.h processing to
allow machines to have config.h.in fragments. While I agree that this
is where we want to go, I don't want to see this cleanup block the ARM
dynamic linker name changes. I've filed
http://sourceware.org/bugzilla/show_bug.cgi?id=14068 to look into the
cleanup.
OK to commit?
2012-05-06 Carlos O'Donell <carlos_odonell@mentor.com>
* config.h.in: Add HAVE_ARM_PCS_VFP.
diff --git a/config.h.in b/config.h.in
index 81704a1..787873b 100644
--- a/config.h.in
+++ b/config.h.in
@@ -218,4 +218,7 @@
#define HAVE_REGEX 1
+/* The ARM hard-float ABI is being used. */
+#undef HAVE_ARM_PCS_VFP
+
#endif
===
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] glibc: Define HAVE_ARM_PCS_VFP
2012-05-07 2:22 [PATCH 2/2] glibc: Define HAVE_ARM_PCS_VFP Carlos O'Donell
@ 2012-05-07 20:05 ` Roland McGrath
2012-05-08 17:54 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2012-05-07 20:05 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: GNU C Library, Joseph S. Myers, libc-ports, Khem Raj
I think that's OK given the cleanup bug already filed.
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] glibc: Define HAVE_ARM_PCS_VFP
2012-05-07 20:05 ` Roland McGrath
@ 2012-05-08 17:54 ` Carlos O'Donell
0 siblings, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2012-05-08 17:54 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU C Library, Joseph S. Myers, libc-ports, Khem Raj
On Mon, May 7, 2012 at 4:04 PM, Roland McGrath <roland@hack.frob.com> wrote:
> I think that's OK given the cleanup bug already filed.
Checked into trunk.
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-08 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-07 2:22 [PATCH 2/2] glibc: Define HAVE_ARM_PCS_VFP Carlos O'Donell
2012-05-07 20:05 ` Roland McGrath
2012-05-08 17:54 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).