[PATCH] hppa: use hidden_def with internal pthread funcs

[PATCH] hppa: use hidden_def with internal pthread funcs

[Mike Frysinger]

This matches what everyone else has done already, and allows to it
to actually compile.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 ports/ChangeLog.hppa                                   | 5 +++++
 ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ports/ChangeLog.hppa b/ports/ChangeLog.hppa
index 201dd01..eeb8d45 100644
--- a/ports/ChangeLog.hppa
+++ b/ports/ChangeLog.hppa
@@ -1,3 +1,8 @@
+2012-11-18  Mike Frysinger  <vapier@gentoo.org>
+
+	* sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c: Replace
+	_internal alias by hidden_def.
+
 2012-11-05  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #14805]
diff --git a/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c b/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c
index 974819e..94dc71a 100644
--- a/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c
+++ b/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c
@@ -90,4 +90,4 @@ __pthread_once (once_control, init_routine)
   return 0;
 }
 weak_alias (__pthread_once, pthread_once)
-strong_alias (__pthread_once, __pthread_once_internal)
+hidden_def (__pthread_once)
-- 
1.7.12.4

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Carlos O'Donell]

On Sun, Nov 18, 2012 at 4:04 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> This matches what everyone else has done already, and allows to it
> to actually compile.

Thanks for this!

I'm sorry for not having pushed this out earlier, since I also have
this change in my local git stash.

I've just pushed out 4 more commits which should be useful to gentoo,
the most important being the implementation of fpu_control.h and
get-rounding-mode.h.

> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  ports/ChangeLog.hppa                                   | 5 +++++
>  ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/ports/ChangeLog.hppa b/ports/ChangeLog.hppa
> index 201dd01..eeb8d45 100644
> --- a/ports/ChangeLog.hppa
> +++ b/ports/ChangeLog.hppa
> @@ -1,3 +1,8 @@
> +2012-11-18  Mike Frysinger  <vapier@gentoo.org>
> +
> +       * sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c: Replace

Wrong architecture ;-)

> +       _internal alias by hidden_def.
> +
>  2012-11-05  Joseph Myers  <joseph@codesourcery.com>
>
>         [BZ #14805]
> diff --git a/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c b/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c
> index 974819e..94dc71a 100644
> --- a/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c
> +++ b/ports/sysdeps/unix/sysv/linux/hppa/nptl/pthread_once.c

Missed copyright year update and merge.

> @@ -90,4 +90,4 @@ __pthread_once (once_control, init_routine)
>    return 0;
>  }
>  weak_alias (__pthread_once, pthread_once)
> -strong_alias (__pthread_once, __pthread_once_internal)
> +hidden_def (__pthread_once)
> --
> 1.7.12.4
>

Checked in.

Cheers,
Carlos.

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 222 bytes --]

On Sunday 18 November 2012 04:04:39 Mike Frysinger wrote:
> This matches what everyone else has done already, and allows to it
> to actually compile.

Carlos: btw, i wasn't going to push this unless you acked it ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Carlos O'Donell]

On Mon, Nov 19, 2012 at 12:46 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Sunday 18 November 2012 04:04:39 Mike Frysinger wrote:
>> This matches what everyone else has done already, and allows to it
>> to actually compile.
>
> Carlos: btw, i wasn't going to push this unless you acked it ...
> -mike

Understood, thanks for that. I was right in the middle of other
commits when you posted this, so I just went ahead and committed it
for you with the copyright and ChangeLog fixes.

Hopefully things are a little better now for hppa, all I have left are
the _STACK_GROWS_UP patches for nptl/.

Cheers,
Carlos.

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 808 bytes --]

On Monday 19 November 2012 00:48:41 Carlos O'Donell wrote:
> On Mon, Nov 19, 2012 at 12:46 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Sunday 18 November 2012 04:04:39 Mike Frysinger wrote:
> >> This matches what everyone else has done already, and allows to it
> >> to actually compile.
> > 
> > Carlos: btw, i wasn't going to push this unless you acked it ...
> 
> Understood, thanks for that. I was right in the middle of other
> commits when you posted this, so I just went ahead and committed it
> for you with the copyright and ChangeLog fixes.

np

> Hopefully things are a little better now for hppa, all I have left are
> the _STACK_GROWS_UP patches for nptl/.

that one should be easy though.  the one we've been carrying from you looks 
pretty straight forward.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Carlos O'Donell]

On Mon, Nov 19, 2012 at 1:11 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> Hopefully things are a little better now for hppa, all I have left are
>> the _STACK_GROWS_UP patches for nptl/.
>
> that one should be easy though.  the one we've been carrying from you looks
> pretty straight forward.

Agreed. I wanted to get the hppa changes in before I started rewriting
allocatestack for BZ#11787[1].

Cheers,
Carlos.

[1] http://sourceware.org/bugzilla/show_bug.cgi?id=11787

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Joseph S. Myers]

On Mon, 19 Nov 2012, Carlos O'Donell wrote:

> Hopefully things are a little better now for hppa, all I have left are
> the _STACK_GROWS_UP patches for nptl/.

I think points (b), (e), (g), (h), (k), (l), (m), (n), (o), (q), (r), (s), 
(t), (u), (v), (x) and (y) from my previous list 
<http://sourceware.org/ml/libc-ports/2012-06/msg00048.html> are still 
current, along with points not on that list:

  (z) There is no c++-types.data for hppa.

  (aa) The TLS configure checks should be removed from
  sysdeps/hppa/configure.in, now the rule is that we assume a
  recent-enough binutils and such checks are no longer needed for each
  architecture and have been removed for other architectures.

  (ab) __ASSUME_LWS_CAS (definition and uses) should be removed now
  2.6.16 is the global minimum kernel version.

  (ac) lll_futex_timed_wait_bitset should be defined for hppa.

(Some of the bits/*.h files where my previous list notes the hppa versions 
are out of date should perhaps be reworked along the lines used for 
bits/fcntl.h to reduce duplication between architecture versions - but 
such a reworking wouldn't be appropriate during a release freeze, whereas 
straightforward updates of the hppa versions would be appropriate then.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Carlos O'Donell]

On Mon, Nov 19, 2012 at 9:32 AM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Mon, 19 Nov 2012, Carlos O'Donell wrote:
>
>> Hopefully things are a little better now for hppa, all I have left are
>> the _STACK_GROWS_UP patches for nptl/.
>
> I think points (b), (e), (g), (h), (k), (l), (m), (n), (o), (q), (r), (s),
> (t), (u), (v), (x) and (y) from my previous list
> <http://sourceware.org/ml/libc-ports/2012-06/msg00048.html> are still
> current, along with points not on that list:
>
>   (z) There is no c++-types.data for hppa.
>
>   (aa) The TLS configure checks should be removed from
>   sysdeps/hppa/configure.in, now the rule is that we assume a
>   recent-enough binutils and such checks are no longer needed for each
>   architecture and have been removed for other architectures.
>
>   (ab) __ASSUME_LWS_CAS (definition and uses) should be removed now
>   2.6.16 is the global minimum kernel version.
>
>   (ac) lll_futex_timed_wait_bitset should be defined for hppa.
>
> (Some of the bits/*.h files where my previous list notes the hppa versions
> are out of date should perhaps be reworked along the lines used for
> bits/fcntl.h to reduce duplication between architecture versions - but
> such a reworking wouldn't be appropriate during a release freeze, whereas
> straightforward updates of the hppa versions would be appropriate then.)

Thanks, that is correct and matches my list of remaining things that
need fixing.

My comment above is simply that with the patches for nptl
_STACK_GROWS_UP cases hppa will be able to compile and work
out-of-the-box without patches.

Cheers,
Carlos.

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Joseph S. Myers]

On Tue, 20 Nov 2012, Carlos O'Donell wrote:

> Thanks, that is correct and matches my list of remaining things that
> need fixing.

Add creating a sotruss-lib.c file as well.  (The lack of sotruss-lib.c 
support is an issue for powerpc, sh, s390 among libc targets - only the 
other libc targets have support directly in the elf/ file - as well as 
alpha am33 hppa ia64 m68k mips.  It came to my attention in my ongoing 
cleanup of compiler warnings from the MIPS build.  So if you clean up 
compiler warnings building for hppa - and I think that is something 
architecture maintainers ought to review for each release, as well as test 
results - then the lack of sotruss-lib.c support will show up for you as 
well.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH] hppa: use hidden_def with internal pthread funcs

[Carlos O'Donell]

On Tue, Nov 20, 2012 at 6:42 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Tue, 20 Nov 2012, Carlos O'Donell wrote:
>
>> Thanks, that is correct and matches my list of remaining things that
>> need fixing.
>
> Add creating a sotruss-lib.c file as well.  (The lack of sotruss-lib.c
> support is an issue for powerpc, sh, s390 among libc targets - only the
> other libc targets have support directly in the elf/ file - as well as
> alpha am33 hppa ia64 m68k mips.  It came to my attention in my ongoing
> cleanup of compiler warnings from the MIPS build.  So if you clean up
> compiler warnings building for hppa - and I think that is something
> architecture maintainers ought to review for each release, as well as test
> results - then the lack of sotruss-lib.c support will show up for you as
> well.)

Thanks, added as point (ad) Add sotruss-lib.c support.

Cheers,
Carlos.