* Implement MIPS n64 sendfile64 as alias of sendfile syscall (bug 14822)
@ 2012-11-22 2:38 Joseph S. Myers
2012-11-22 2:41 ` Carlos O'Donell
0 siblings, 1 reply; 2+ messages in thread
From: Joseph S. Myers @ 2012-11-22 2:38 UTC (permalink / raw)
To: libc-ports
Bug 14822 notes that MIPS n64 is missing an actual sendfile64
implementation. The n64 syscall interface has only a sendfile syscall
(o32 and n32 both have both sendfile and sendfile64 syscalls), and
since this function does not have struct stat involved in its
interface it's correct for sendfile and sendfile64 to be aliases for
n64. Thus this patch fixes this issue by making n64 handle this
syscall the same as sysdeps/unix/sysv/linux/wordsize-64.
2012-11-22 Joseph Myers <joseph@codesourcery.com>
[BZ #14822]
* sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list
(sendfile): New syscall entry.
* sysdeps/unix/sysv/linux/mips/mips64/n64/sendfile64.c: New file.
Copy of ../sysdeps/unix/sysv/linux/wordsize-64/sendfile64.c.
diff --git a/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/sendfile64.c b/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/sendfile64.c
new file mode 100644
index 0000000..4c451bd
--- /dev/null
+++ b/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/sendfile64.c
@@ -0,0 +1 @@
+/* sendfile64 is alias of sendfile syscall. */
diff --git a/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list b/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list
index c94fe75..b23a2a1 100644
--- a/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list
+++ b/ports/sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list
@@ -8,3 +8,5 @@ fanotify_mark EXTRA fanotify_mark i:iiiis fanotify_mark
fstatfs - fstatfs i:ip __fstatfs fstatfs fstatfs64 __fstatfs64
statfs - statfs i:sp __statfs statfs statfs64 __statfs64
+
+sendfile - sendfile i:iipi sendfile sendfile64
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Implement MIPS n64 sendfile64 as alias of sendfile syscall (bug 14822)
2012-11-22 2:38 Implement MIPS n64 sendfile64 as alias of sendfile syscall (bug 14822) Joseph S. Myers
@ 2012-11-22 2:41 ` Carlos O'Donell
0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2012-11-22 2:41 UTC (permalink / raw)
To: Joseph S. Myers; +Cc: libc-ports
On Wed, Nov 21, 2012 at 9:38 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> Bug 14822 notes that MIPS n64 is missing an actual sendfile64
> implementation. The n64 syscall interface has only a sendfile syscall
> (o32 and n32 both have both sendfile and sendfile64 syscalls), and
> since this function does not have struct stat involved in its
> interface it's correct for sendfile and sendfile64 to be aliases for
> n64. Thus this patch fixes this issue by making n64 handle this
> syscall the same as sysdeps/unix/sysv/linux/wordsize-64.
>
> 2012-11-22 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #14822]
> * sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list
> (sendfile): New syscall entry.
> * sysdeps/unix/sysv/linux/mips/mips64/n64/sendfile64.c: New file.
> Copy of ../sysdeps/unix/sysv/linux/wordsize-64/sendfile64.c.
Thanks for fixing this.
I'm sure Yijun (the submitter) will be excited to see this fixed.
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-22 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-22 2:38 Implement MIPS n64 sendfile64 as alias of sendfile syscall (bug 14822) Joseph S. Myers
2012-11-22 2:41 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).