From: "Carlos O'Donell" <carlos@systemhalted.org>
To: Steve Ellcey <sellcey@mips.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>
Subject: Re: [Patch, mips] Faster strcmp for mips
Date: Fri, 15 Nov 2013 18:48:00 -0000 [thread overview]
Message-ID: <CAE2sS1jDnPP2hKn6u-nnvAnKgwQrrVUsDUrGWjyUu8+EBXZjgA@mail.gmail.com> (raw)
In-Reply-To: <1384464221.2484.86.camel@ubuntu-sellcey>
On Thu, Nov 14, 2013 at 4:23 PM, Steve Ellcey <sellcey@mips.com> wrote:
> This means it could be loading bytes beyond the end of the strings being
> compared but it looks like other architecture specific strcmp functions
> are also doing this optimization and the newlib version of strcmp also does
> this.
I thought that doing so was dangerous? I'm pretty sure we've been trying
to fix such "load bytes beyond the end of the string" issues because you
could have a string that straddles a page boundary with the next page
unmapped and such an optimized routine would fault on a read from the
unmapped page.
How do you plan to fix that?
Cheers,
Carlos.
next prev parent reply other threads:[~2013-11-15 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 21:25 Steve Ellcey
2013-11-14 23:14 ` Ondřej Bílka
2013-11-15 18:21 ` Steve Ellcey
2013-11-15 19:02 ` Ondřej Bílka
2013-11-18 23:50 ` Steve Ellcey
2013-11-19 2:32 ` Ondřej Bílka
2013-11-15 18:48 ` Carlos O'Donell [this message]
2013-11-15 18:53 ` Steve Ellcey
2013-11-15 18:59 ` Carlos O'Donell
2015-02-19 7:25 ` Matt Turner
2015-02-19 18:12 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2sS1jDnPP2hKn6u-nnvAnKgwQrrVUsDUrGWjyUu8+EBXZjgA@mail.gmail.com \
--to=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).