From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Venkataramanan Kumar <venkataramanan.kumar@linaro.org>
Cc: libc-ports@sourceware.org, Patch Tracking <patch@linaro.org>
Subject: Re: [PATCH] [AARCH64]: Pointer mangling support for Aarch64
Date: Fri, 10 Jan 2014 10:40:00 -0000 [thread overview]
Message-ID: <CAFqB+Pw2jPnpiNhmyNyOHU4O4vRL9mQ45SwOxttM2Mbzyg-MAg@mail.gmail.com> (raw)
In-Reply-To: <CAJK_mQ2QCwEsV4-o6pha+jcN9dNDoRuKMP9vCWd6kvsf-K9yYg@mail.gmail.com>
On 8 January 2014 10:32, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Also looking at x86 and powerpc ports.
> They pass argument 1 - the address of jump buffer
> argument 2 - return value of __longjmp
> argument 3 - PC address or the jump target
> For Aarch64, the longjmp/longjmp_target probe passed as below.
> * first argument - 8@address of jmpbuf in x0.
> * second argument- -4@return val in x1.
> * third argument- 8@ PC address or jump target target in LR/X30.
OK, so the arguments to the LIBC_PROBES in your patch look sensible.
> is that fine?
I'd like to see follow up to Will's question regarding placement of
the two probes.
>
>>
>> Do we need probes in setjmp aswell?
>
> Ok, I will add that as well.
> I have not yet tested, the patch by enabling --enable-systemtap as it
The patch needs to be tested ;-)
Cheers
/Marcus
prev parent reply other threads:[~2014-01-10 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 12:25 Venkataramanan Kumar
2013-12-26 19:33 ` Richard Henderson
2013-12-27 7:48 ` Venkataramanan Kumar
2013-12-27 15:09 ` Richard Henderson
2013-12-30 5:00 ` Venkataramanan Kumar
2013-12-30 14:45 ` Richard Henderson
2013-12-30 15:36 ` Venkataramanan Kumar
2013-12-30 22:20 ` Marcus Shawcroft
2013-12-31 5:15 ` Venkataramanan Kumar
2014-01-01 17:42 ` Marcus Shawcroft
2014-01-06 18:11 ` Tom Tromey
2014-01-07 11:05 ` Venkataramanan Kumar
2014-01-07 12:17 ` Marcus Shawcroft
2014-01-07 18:10 ` Tom Tromey
2014-01-10 9:54 ` Will Newton
2014-01-20 9:01 ` Will Newton
2014-01-20 16:45 ` Tom Tromey
2014-01-20 17:02 ` Will Newton
2014-01-08 10:32 ` Venkataramanan Kumar
2014-01-10 10:40 ` Marcus Shawcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqB+Pw2jPnpiNhmyNyOHU4O4vRL9mQ45SwOxttM2Mbzyg-MAg@mail.gmail.com \
--to=marcus.shawcroft@gmail.com \
--cc=libc-ports@sourceware.org \
--cc=patch@linaro.org \
--cc=venkataramanan.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).