public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Will Newton <will.newton@linaro.org>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-ports@sourceware.org, Patch Tracking <patches@linaro.org>
Subject: Re: [PATCH, v6] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
Date: Wed, 08 May 2013 09:44:00 -0000	[thread overview]
Message-ID: <CANu=Dmi+5X64F3+yGsWXEdKqGW5PxjaXvBaGCtds9Obp057cNA@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1305041312390.658@digraph.polyomino.org.uk>

On 4 May 2013 14:13, Joseph S. Myers <joseph@codesourcery.com> wrote:

Hi Joseph,

> On Fri, 3 May 2013, Will Newton wrote:
>
>> On 3 May 2013 21:18, Joseph S. Myers <joseph@codesourcery.com> wrote:
>>
>> Hi Joseph,
>>
>> >> This was tested on armv7l-unknown-linux-gnueabihf. One new testsuite
>> >
>> > I think string functions also need big-endian testing (which should be
>> > possible with userspace QEMU - you should be able to run the string tests
>> > that way, though not the whole testsuite).  If such testing passes, this
>> > version is OK (though as Roland notes there's scope for further
>> > optimization in the __ARM_NEON__ case).
>>
>> I have tested the same code using a big-endian qemu with the
>> cortex-strings tests which are taken from glibc:
>>
>> http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/view/head:/tests/test-memcpy.c
>>
>> I haven't built glibc big-endian yet, but I can do that if you think
>> it would be valuable.
>
> Yes, I believe this should be tested with the current glibc string tests
> for a big-endian build of glibc.

I can confirm test-memcpy and test-memcpy-ifunc both pass under big endian qemu.


--
Will Newton
Toolchain Working Group, Linaro

  reply	other threads:[~2013-05-08  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 19:49 Will Newton
2013-05-03 20:19 ` Joseph S. Myers
2013-05-03 21:14   ` Will Newton
2013-05-04 13:13     ` Joseph S. Myers
2013-05-08  9:44       ` Will Newton [this message]
2013-05-08 12:07         ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANu=Dmi+5X64F3+yGsWXEdKqGW5PxjaXvBaGCtds9Obp057cNA@mail.gmail.com' \
    --to=will.newton@linaro.org \
    --cc=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).