From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
libc-ports@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
Kaz Kojima <kkojima@rr.iij4u.or.jp>,
Andreas Krebbel <Andreas.Krebbel@de.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: RFA: Port maintainers: Convert WORDSIZE[32|64]/ld to abi-variants
Date: Fri, 01 Jun 2012 15:07:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1206011506140.2129@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CAMe9rOr0WQgOFXOac8PzYHZk9DeiZ2OSmJEG7tgq0bJ0CFUQLA@mail.gmail.com>
On Fri, 1 Jun 2012, H.J. Lu wrote:
> > Here is the (untested) patch I propose to add the default-abi definitions
> > so that these architectures again install the correct stubs-<abi>.h
> > instead of "stubs-.h".
>
> Can you also remove
>
> ifdef abi-variants
> ifndef default-abi
> default-abi = $(firstword $(abi-variants))
> endif
> endif
>
> in Makeconfig?
Here is a patch for that. Tested x86_64.
2012-06-01 Joseph Myers <joseph@codesourcery.com>
* Makeconfig [abi-variants && !default-abi] (default-abi): Remove
definition. Document in comment.
diff --git a/Makeconfig b/Makeconfig
index df7545f..cba5db7 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -797,13 +797,8 @@ ifeq (yes, $(build-shared))
# defines abi-$(variant)-condition to be the condition for those options
# to use in a C #if condition. abi-includes may be defined to a list of
# headers to include in the generated header, if the default does not
-# suffice.
-
-ifdef abi-variants
-ifndef default-abi
-default-abi = $(firstword $(abi-variants))
-endif
-endif
+# suffice. default-abi is defined to be the ABI for the current glibc
+# build.
ifndef abi-includes
abi-includes := bits/wordsize.h
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-06-01 15:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:37 H.J. Lu
2012-05-26 17:03 ` Joseph S. Myers
2012-05-26 17:51 ` H.J. Lu
2012-05-26 19:22 ` Joseph S. Myers
2012-05-26 20:42 ` H.J. Lu
2012-05-30 0:29 ` H.J. Lu
2012-05-30 0:39 ` David Miller
2012-05-30 3:15 ` David Miller
2012-05-30 3:27 ` H.J. Lu
2012-05-30 8:49 ` Andreas Krebbel
2012-05-30 13:00 ` H.J. Lu
2012-05-31 15:17 ` Joseph S. Myers
2012-05-31 15:32 ` H.J. Lu
2012-06-01 14:06 ` Joseph S. Myers
2012-06-01 14:21 ` H.J. Lu
2012-06-01 15:07 ` Joseph S. Myers [this message]
2012-06-01 15:27 ` H.J. Lu
2012-06-01 20:16 ` Joseph S. Myers
2012-06-01 20:32 ` Roland McGrath
2012-05-30 18:58 ` Thomas Schwinge
2012-05-30 19:00 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1206011506140.2129@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Andreas.Krebbel@de.ibm.com \
--cc=davem@davemloft.net \
--cc=hjl.tools@gmail.com \
--cc=kkojima@rr.iij4u.or.jp \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).