From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Maxim Kuvyrkov <maxim@codesourcery.com>
Cc: <libc-ports@sourceware.org>,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [PATCH 1/3, MIPS] Rewrite MIPS' atomic.h to use __atomic_* builtins.
Date: Thu, 28 Jun 2012 23:00:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1206282256570.20312@digraph.polyomino.org.uk> (raw)
In-Reply-To: <26D032BF-62BA-46CE-AD1B-05620E7D9A4C@codesourcery.com>
On Thu, 28 Jun 2012, Maxim Kuvyrkov wrote:
> Here is an updated patch fixed per above comments.
This is OK for 2.17 (that is, for the ports subdirectory in the libc
repository once that merge has been done, reviewed and is on master and
the commit moratorium has been explicitly lifted), with the following
change.
> +/* ??? Barrier semantics for atomic_exchange_and_add appear to be
> + undefined. Use full barrier for now, as that's safe. */
Please file a bug to clarify these semantics, if not already filed, and
reference it in the comment. (Clarifying the semantics will I suppose
involve examining both direct and indirect users of
atomic_exchange_and_add to work out what they need and whether it should
be split into multiple macros with different barrier semantics.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-06-28 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 4:27 Maxim Kuvyrkov
2012-06-14 6:00 ` Maxim Kuvyrkov
2012-06-14 11:07 ` Joseph S. Myers
2012-06-15 5:07 ` Maxim Kuvyrkov
2012-06-15 11:25 ` Joseph S. Myers
2012-06-27 22:04 ` Maxim Kuvyrkov
2012-06-28 23:00 ` Joseph S. Myers [this message]
2012-07-11 9:50 ` [PATCH] Add explicit acquire/release semantics to atomic_exchange_and_add Maxim Kuvyrkov
2012-07-13 17:29 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1206282256570.20312@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=maxim@codesourcery.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).