From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-atomic] ARM: split generic and Linux-specific bits/atomic.h
Date: Fri, 21 Sep 2012 23:43:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1209212342460.14158@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20120814235134.18B7B2C0EC@topped-with-meat.com>
This patch <http://sourceware.org/ml/libc-ports/2012-08/msg00122.html>
caused around 150 test failures for pre-v6/v7 ARM systems using the
kernel helpers, because the arguments in a call to
__arm_assisted_compare_and_exchange_val_32_acq were the wrong way
round. I've applied this patch to fix this.
2012-09-21 Joseph Myers <joseph@codesourcery.com>
* sysdeps/arm/bits/atomic.h [!__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4]
(__arch_compare_and_exchange_val_32_acq): Correct order of
arguments of __arm_assisted_compare_and_exchange_val_32_acq.
diff --git a/ports/sysdeps/arm/bits/atomic.h b/ports/sysdeps/arm/bits/atomic.h
index 9984210..39e276f 100644
--- a/ports/sysdeps/arm/bits/atomic.h
+++ b/ports/sysdeps/arm/bits/atomic.h
@@ -58,7 +58,7 @@ void __arm_link_error (void);
__sync_val_compare_and_swap ((mem), (oldval), (newval))
#else
# define __arch_compare_and_exchange_val_32_acq(mem, newval, oldval) \
- __arm_assisted_compare_and_exchange_val_32_acq ((mem), (oldval), (newval))
+ __arm_assisted_compare_and_exchange_val_32_acq ((mem), (newval), (oldval))
#endif
/* We don't support atomic operations on any non-word types.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2012-09-21 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 23:51 Roland McGrath
2012-08-15 9:56 ` Joseph S. Myers
2012-08-15 16:41 ` Roland McGrath
2012-09-21 23:43 ` Joseph S. Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1209212342460.14158@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).