public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [patch, mips] Fix for mips64 ieee754.h header file
@ 2012-10-01 17:48 Steve Ellcey 
  2012-10-03 21:12 ` Joseph S. Myers
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Ellcey  @ 2012-10-01 17:48 UTC (permalink / raw)
  To: libc-ports


This patch is to ensure a consistent set of headers across various mips
platforms.  Currently mips32 platforms use ieee754.h from the sysdeps/mips
directory but mips64 targets use ieee754.h from sysdeps/ieee754/ldbl-128.
The one from sysdeps/mips can handle 64 bit or 128 bit long doubles and
the one from sysdeps/ieee754/ldbl-128 only handles 128 bit long doubles.

This change causes mips32 and mips64 targets to use the one from sysdeps/mips.
To make sure I don't mess up any other header files I moved ieee754.h
from the mips directory to mips/ieee754 so I could put it at the head of the
Implies list and not affect anything else.  I then changed Implies for mips32
(so that it doesn't change behaviour) and for mips64 so that it does change
behaviour and uses the mips specific ieee754.h file.

Tested on mips32, mips32r2, mips64, and mips64r2 builds with the o32, n32,
and 64 bit ABIs.

OK to checkin?

Steve Ellcey
sellcey@mips.com



2012-10-01  Steve Ellcey  <sellcey@mips.com>

	* ports/sysdeps/mips/ieee754.h: Move to...
	* ports/sysdeps/mips/ieee754/ieee754.h: Here.
	* ports/sysdeps/mips/mips32/Implies: Add mips/ieee754.
	* ports/sysdeps/mips/mips64/Implies: Ditto.
	* ports/sysdeps/mips/mips64/n32/Implies: Ditto.
	* ports/sysdeps/mips/mips64/n64/Implies: Ditto.


diff --git a/ports/sysdeps/mips/mips32/Implies b/ports/sysdeps/mips/mips32/Implies
index fab98d7..6473f25 100644
--- a/ports/sysdeps/mips/mips32/Implies
+++ b/ports/sysdeps/mips/mips32/Implies
@@ -1,2 +1,3 @@
+mips/ieee754
 mips
 wordsize-32
diff --git a/ports/sysdeps/mips/mips64/Implies b/ports/sysdeps/mips/mips64/Implies
index 8c18cb3..826ff15 100644
--- a/ports/sysdeps/mips/mips64/Implies
+++ b/ports/sysdeps/mips/mips64/Implies
@@ -1,3 +1,4 @@
 # MIPS uses IEEE 754 floating point.
+mips/ieee754
 ieee754/flt-32
 ieee754/dbl-64
diff --git a/ports/sysdeps/mips/mips64/n32/Implies b/ports/sysdeps/mips/mips64/n32/Implies
index bed8f14..9ab2f32 100644
--- a/ports/sysdeps/mips/mips64/n32/Implies
+++ b/ports/sysdeps/mips/mips64/n32/Implies
@@ -1,3 +1,4 @@
+mips/ieee754
 ieee754/ldbl-128
 mips/mips64/soft-fp
 mips/mips64
diff --git a/ports/sysdeps/mips/mips64/n64/Implies b/ports/sysdeps/mips/mips64/n64/Implies
index 214b85c..de23ed1 100644
--- a/ports/sysdeps/mips/mips64/n64/Implies
+++ b/ports/sysdeps/mips/mips64/n64/Implies
@@ -1,3 +1,4 @@
+mips/ieee754
 ieee754/ldbl-128
 mips/mips64/soft-fp
 mips/mips64

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch, mips] Fix for mips64 ieee754.h header file
  2012-10-01 17:48 [patch, mips] Fix for mips64 ieee754.h header file Steve Ellcey 
@ 2012-10-03 21:12 ` Joseph S. Myers
  0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2012-10-03 21:12 UTC (permalink / raw)
  To: Steve Ellcey; +Cc: libc-ports

On Mon, 1 Oct 2012, Steve Ellcey  wrote:

> 2012-10-01  Steve Ellcey  <sellcey@mips.com>
> 
> 	* ports/sysdeps/mips/ieee754.h: Move to...
> 	* ports/sysdeps/mips/ieee754/ieee754.h: Here.
> 	* ports/sysdeps/mips/mips32/Implies: Add mips/ieee754.
> 	* ports/sysdeps/mips/mips64/Implies: Ditto.
> 	* ports/sysdeps/mips/mips64/n32/Implies: Ditto.
> 	* ports/sysdeps/mips/mips64/n64/Implies: Ditto.

OK, but fix the ChangeLog entry (it goes in ports/ChangeLog.mips and the 
paths in that file are relative to that directory, so do not have the 
initial ports/ component).

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-03 21:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-01 17:48 [patch, mips] Fix for mips64 ieee754.h header file Steve Ellcey 
2012-10-03 21:12 ` Joseph S. Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).