From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Marcus Shawcroft <marcus.shawcroft@linaro.org>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH 1/2] AArch64 glibc port
Date: Wed, 07 Nov 2012 13:09:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1211071306210.32199@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CABXK9ndfSEpyP40xo8MPnv9zA7hp=Tp+dMg6QcqqcKf3TzYn1w@mail.gmail.com>
On Wed, 7 Nov 2012, Marcus Shawcroft wrote:
> This resolves the majority of the outstanding issues. The solution
> above is not quite sufficient because given a true 0, FP_ROUND may set
> working bits resulting in the underflow test failing. I resolved this
> by adjusting FP_ROUND such that it does not attempt to round a true
> zero, is that sane? I've attached my current patch. The patch is
I think it would be better to put all the rounding logic inside the
existing "if (_FP_FRAC_LOW_##wc(X) & 7)" conditional that determines
whether to set the INEXACT exception - if none of the low three bits is
set, there's no point in doing anything for rounding.
soft-fp patches should go to libc-alpha. (Once checked in, the patch to
update all the soft-fp files in libgcc from their soft-fp versions goes to
gcc-patches, of course.)
> against glibc/soft-fp but I've actually be using it applied to
> libgcc/soft-fp. What is the recommend way to test patches to soft-fp
> in glibc?
You could ask the architecture maintainer of an architecture that uses
soft-fp in glibc (e.g. SPARC) to test it, though I think testing in libgcc
is just as useful.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2012-11-07 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABXK9nfac4O=A0SMe_3FvTnqjpTDF0bDkd6inTBeSbK6DUtWOw@mail.gmail.com>
2012-10-03 22:11 ` Joseph S. Myers
2012-11-02 17:27 ` Marcus Shawcroft
2012-11-03 18:17 ` Joseph S. Myers
2012-11-05 17:02 ` Marcus Shawcroft
2012-11-05 18:06 ` Joseph S. Myers
2012-11-07 12:35 ` Marcus Shawcroft
2012-11-07 13:09 ` Joseph S. Myers [this message]
[not found] ` <CABXK9nfUuGCf2d8L4+ZnAMS+jdm_uMDcgTL619nbdHdpNEw_FQ@mail.gmail.com>
2012-11-07 15:16 ` Joseph S. Myers
2012-11-08 8:09 ` Fwd: " Marcus Shawcroft
2012-11-08 18:14 ` Joseph S. Myers
2012-11-08 21:26 ` Richard Henderson
2012-11-08 23:13 ` Joseph S. Myers
2012-11-09 18:07 ` Marcus Shawcroft
2012-11-09 19:35 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1211071306210.32199@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=marcus.shawcroft@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).