From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support
Date: Wed, 23 Jan 2013 17:06:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1301231704230.7102@digraph.polyomino.org.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1301230241530.4834@tp.orcam.me.uk>
On Wed, 23 Jan 2013, Maciej W. Rozycki wrote:
> +#ifdef __mips_micromips
> +#define MOVE32 "move32"
> +#else
> +#define MOVE32 "move"
> +#endif
Indent preprocessor directives inside #if, so "# define", here and in the
other instances of this code in the patch.
> + register long __s0 asm("$16") __attribute__((unused)) = number; \
Space between __attribute__ and ((unused)), everywhere this construct
appears in this patch.
OK with those whitespace fixes; remember to update the list of fixed bugs
in the NEWS file (a single list is used for both libc and ports bugs) as
part of your commit of the fix, and to close the bug as fixed afterwards.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-01-23 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 3:09 Maciej W. Rozycki
2013-01-23 5:05 ` Mike Frysinger
2013-01-23 5:40 ` Maciej W. Rozycki
2013-01-23 18:13 ` Mike Frysinger
2013-01-29 18:12 ` Maciej W. Rozycki
2013-01-29 19:04 ` Ralf Baechle
2013-01-29 19:12 ` Maciej W. Rozycki
2013-01-30 1:26 ` Ralf Baechle
2013-01-30 6:50 ` Mike Frysinger
2013-01-23 17:06 ` Joseph S. Myers [this message]
2013-01-24 12:47 ` Maciej W. Rozycki
2013-01-24 16:31 ` Joseph S. Myers
2013-01-29 18:10 ` Maciej W. Rozycki
2013-01-29 23:59 ` Joseph S. Myers
2013-02-05 15:26 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1301231704230.7102@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).