public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Macroize use of .cfi_sections directive.
@ 2013-02-28  0:43 Roland McGrath
  2013-02-28  0:56 ` Joseph S. Myers
  0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2013-02-28  0:43 UTC (permalink / raw)
  To: libc-ports

Some future ARM configurations might use DWARF2 CFI rather than EABI.
Using a macro for .cfi_sections makes it easy for a new sysdep.h file
to override the choice.


Thanks,
Roland


ports/ChangeLog.arm
2013-02-27  Roland McGrath  <roland@hack.frob.com>

	* sysdeps/arm/sysdep.h (CFI_SECTIONS): New macro.
	(ENTRY): Use it.
	* sysdeps/arm/dl-tlsdesc.S: Likewise.
	* sysdeps/arm/dl-trampoline.S: Likewise.
	* sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h (PSEUDO): Likewise.

--- a/ports/sysdeps/arm/dl-tlsdesc.S
+++ b/ports/sysdeps/arm/dl-tlsdesc.S
@@ -29,7 +29,7 @@
 	.text
 	@ emit debug information with cfi
 	@ use arm-specific pseudos for unwinding itself
-	.cfi_sections .debug_frame
+	CFI_SECTIONS
 	.hidden _dl_tlsdesc_return
 	.global	_dl_tlsdesc_return
 	.type	_dl_tlsdesc_return,#function
--- a/ports/sysdeps/arm/dl-trampoline.S
+++ b/ports/sysdeps/arm/dl-trampoline.S
@@ -28,7 +28,7 @@
 	.text
 	.globl _dl_runtime_resolve
 	.type _dl_runtime_resolve, #function
-	.cfi_sections .debug_frame
+	CFI_SECTIONS
 	cfi_startproc
 	.align 2
 _dl_runtime_resolve:
@@ -77,7 +77,7 @@ _dl_runtime_resolve:
 #ifndef PROF
 	.globl _dl_runtime_profile
 	.type _dl_runtime_profile, #function
-	.cfi_sections .debug_frame
+	CFI_SECTIONS
 	cfi_startproc
 	.align 2
 _dl_runtime_profile:
--- a/ports/sysdeps/arm/sysdep.h
+++ b/ports/sysdeps/arm/sysdep.h
@@ -63,10 +63,13 @@
   .type C_SYMBOL_NAME(name),%function;					      \
   .align ALIGNARG(4);							      \
   C_LABEL(name)								      \
-  .cfi_sections .debug_frame;						      \
+  CFI_SECTIONS;								      \
   cfi_startproc;							      \
   CALL_MCOUNT
 
+#define CFI_SECTIONS							      \
+  .cfi_sections .debug_frame
+
 #undef	END
 #define END(name)							      \
   cfi_endproc;								      \
--- a/ports/sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h
+++ b/ports/sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h
@@ -35,7 +35,7 @@
   .type __##syscall_name##_nocancel,%function;				\
   .globl __##syscall_name##_nocancel;					\
   __##syscall_name##_nocancel:						\
-    .cfi_sections .debug_frame;						\
+    CFI_SECTIONS;							\
     cfi_startproc;							\
     DO_CALL (syscall_name, args);					\
     cmn r0, $4096;							\

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: Macroize use of .cfi_sections directive.
  2013-02-28  0:43 [PATCH] ARM: Macroize use of .cfi_sections directive Roland McGrath
@ 2013-02-28  0:56 ` Joseph S. Myers
  0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2013-02-28  0:56 UTC (permalink / raw)
  To: Roland McGrath; +Cc: libc-ports

On Wed, 27 Feb 2013, Roland McGrath wrote:

> 2013-02-27  Roland McGrath  <roland@hack.frob.com>
> 
> 	* sysdeps/arm/sysdep.h (CFI_SECTIONS): New macro.
> 	(ENTRY): Use it.
> 	* sysdeps/arm/dl-tlsdesc.S: Likewise.
> 	* sysdeps/arm/dl-trampoline.S: Likewise.
> 	* sysdeps/unix/sysv/linux/arm/nptl/sysdep-cancel.h (PSEUDO): Likewise.

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-28  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-28  0:43 [PATCH] ARM: Macroize use of .cfi_sections directive Roland McGrath
2013-02-28  0:56 ` Joseph S. Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).