From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-avoid-pc] ARM_BX_ALIGN_LOG2
Date: Tue, 12 Mar 2013 23:40:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1303122339020.6338@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130311205518.977F12C08D@topped-with-meat.com>
On Mon, 11 Mar 2013, Roland McGrath wrote:
> +/* The log2 of the minimum alignment required for an address that
> + is the target of a computed branch (i.e. a "bx" instruction).
> + A more-specific arm-features.h file may define this to set a more
> + stringent requirement. */
The comment should say that this should only be used in ARM-mode code
(certainly this definition doesn't make sense by default for code built as
Thumb). OK with that change.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-03-12 23:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 20:54 [PATCH roland/arm-avoid-pc] ARM: Support avoiding pc as destination register Roland McGrath
2013-03-11 20:55 ` [PATCH roland/arm-avoid-pc] ARM_BX_ALIGN_LOG2 Roland McGrath
2013-03-12 23:40 ` Joseph S. Myers [this message]
2013-03-13 19:42 ` Roland McGrath
2013-03-12 23:35 ` [PATCH roland/arm-avoid-pc] ARM: Support avoiding pc as destination register Joseph S. Myers
2013-03-13 16:50 ` Roland McGrath
-- strict thread matches above, loose matches on Subject: below --
2013-03-04 23:33 [PATCH roland/arm-avoid-pc] ARM_BX_ALIGN_LOG2 Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1303122339020.6338@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).