* [PATCH roland/arm-avoid-pc] ARM: Handle ARM_ALWAYS_BX in {add,sub}_n.S code.
@ 2013-03-11 21:31 Roland McGrath
2013-03-12 23:41 ` Joseph S. Myers
0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2013-03-11 21:31 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-ports
This is on the same unmerged branch, so assumes at least the first patch.
OK?
Thanks,
Roland
ports/ChangeLog.arm
* sysdeps/arm/add_n.S: Include <arm-features.h>.
[ARM_ALWAYS_BX]: Don't pop into pc.
--- a/ports/sysdeps/arm/add_n.S
+++ b/ports/sysdeps/arm/add_n.S
@@ -17,6 +17,7 @@
<http://www.gnu.org/licenses/>. */
#include <sysdep.h>
+#include <arm-features.h>
.syntax unified
.text
@@ -80,5 +81,10 @@ ENTRY (FUNC)
9:
RETC /* copy carry out */
+#ifndef ARM_ALWAYS_BX
pop { r4, r5, r6, r7, r8, r10, pc }
+#else
+ pop { r4, r5, r6, r7, r8, r10, lr }
+ bx lr
+#endif
END (FUNC)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH roland/arm-avoid-pc] ARM: Handle ARM_ALWAYS_BX in {add,sub}_n.S code.
2013-03-11 21:31 [PATCH roland/arm-avoid-pc] ARM: Handle ARM_ALWAYS_BX in {add,sub}_n.S code Roland McGrath
@ 2013-03-12 23:41 ` Joseph S. Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph S. Myers @ 2013-03-12 23:41 UTC (permalink / raw)
To: Roland McGrath; +Cc: libc-ports
On Mon, 11 Mar 2013, Roland McGrath wrote:
> ports/ChangeLog.arm
> * sysdeps/arm/add_n.S: Include <arm-features.h>.
> [ARM_ALWAYS_BX]: Don't pop into pc.
OK.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-12 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 21:31 [PATCH roland/arm-avoid-pc] ARM: Handle ARM_ALWAYS_BX in {add,sub}_n.S code Roland McGrath
2013-03-12 23:41 ` Joseph S. Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).