public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH 1/2 roland/arm-sfi-macros] ARM: sfi_breg assembler macro
Date: Fri, 15 Mar 2013 01:49:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1303150144180.30214@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130313230841.B880B2C097@topped-with-meat.com>

On Wed, 13 Mar 2013, Roland McGrath wrote:

> 	* sysdeps/arm/sysdep.h [!ARM_SFI_MACROS]
> 	(ARM_SFI_MACROS): Define it.
> 	(sfi_breg, sfi_pld): New assembler macros.
> 	* sysdeps/arm/__longjmp.S: Use them for all memory references not
> 	through the pc or sp registers.
> 	* sysdeps/arm/add_n.S: Likewise.
> 	* sysdeps/arm/addmul_1.S: Likewise.
> 	* sysdeps/arm/arm-mcount.S: Likewise.
> 	* sysdeps/arm/armv6/rawmemchr.S: Likewise.
> 	* sysdeps/arm/armv6/strchr.S: Likewise.
> 	* sysdeps/arm/armv6/strcpy.S: Likewise.
> 	* sysdeps/arm/armv6/strlen.S: Likewise.
> 	* sysdeps/arm/armv6/strrchr.S: Likewise.
> 	* sysdeps/arm/armv6t2/memchr.S: Likewise.
> 	* sysdeps/arm/memcpy.S: Likewise.
> 	* sysdeps/arm/memmove.S: Likewise.
> 	* sysdeps/arm/memset.S: Likewise.
> 	* sysdeps/arm/setjmp.S: Likewise.
> 	* sysdeps/arm/strlen.S: Likewise.
> 	* sysdeps/arm/submul_1.S: Likewise.

OK, supposing that the changes to the iWMMXt code in setjmp / longjmp are 
deliberate to avoid potential confusion from parts of a source file using 
this pattern and other parts not using it.  (Given that the document 
pointed to implies that NaCl will define ARM_ASSUME_NO_IWMMXT, so the 
iWMMXt code won't ever actually be built with the non-null version of this 
macro.)

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2013-03-15  1:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 23:09 Roland McGrath
2013-03-13 23:14 ` [PATCH 2/2 roland/arm-sfi-macros] ARM: sfi_sp " Roland McGrath
2013-03-15  1:52   ` Joseph S. Myers
2013-03-15  1:49 ` Joseph S. Myers [this message]
2013-03-15 16:25   ` [PATCH 1/2 roland/arm-sfi-macros] ARM: sfi_breg " Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1303150144180.30214@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    --cc=roland@hack.frob.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).