From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: Dynamic VFP support and math/test-fpucw
Date: Mon, 17 Jun 2013 21:40:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1306172135580.15498@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130617194154.2287E2C095@topped-with-meat.com>
On Mon, 17 Jun 2013, Roland McGrath wrote:
> You could override the test with a sysdeps/arm/test-fpucw.c.
> You could override the installed fpu_control.h with a
> sysdeps/arm/include/fpu_control.h that tests NOT_IN_libc or something.
The trouble is, those options seem rather fragile as well. Maybe the
least bad is overriding the test with a file that just defines e.g.
_LIBC_TEST and includes the main test-fpucw.c (with fpu_control.h then
checking _LIBC_TEST). The difficulty with the second is that dynamic VFP
detection is used in both libc and libm, so NOT_IN_libc isn't sufficient
on its own. Really I suppose what's wanted, in the absence of not
defining _LIBC for tests, would be a macro such as IN_tests that gets
automatically defined for testcase code; then at least fpu_control.h could
test that after _LIBC (if it's only tested conditional on _LIBC, namespace
issues wouldn't matter for IN_tests because no user application should
ever define _LIBC).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-06-17 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 19:18 Joseph S. Myers
2013-06-17 19:41 ` Roland McGrath
2013-06-17 21:40 ` Joseph S. Myers [this message]
2013-06-17 22:03 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1306172135580.15498@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).