From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-strlen] Make armv6t2 strlen work in ARM mode too.
Date: Fri, 30 Aug 2013 20:36:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1308302036190.22363@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20130830180620.77DD12C072@topped-with-meat.com>
On Fri, 30 Aug 2013, Roland McGrath wrote:
> I tested that this has no effect (assembled code wholly unchanged) on
> arm-linux-gnueabihf. I tested that the ARM-mode support actually works by
> hacking in "#define NO_THUMB" at the top and verifying no failures from
> 'make check subdirs=string'.
>
> Incidentally, assembly writers really ought to write more comments! For
> example, I deduced the only plausible reason for using an explicit bne.w
> and added a comment about it, but it is exactly the sort of non-obvious
> subtle microoptimization that desperately needed clear comments in the
> first place.
>
>
> OK for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2013-08-30 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 18:06 Roland McGrath
2013-08-30 20:36 ` Joseph S. Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1308302036190.22363@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).