From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>,
Chung-Lin Tang <cltang@codesourcery.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, <libc-ports@sourceware.org>
Subject: Re: [PATCH 2/2] MIPS16: MIPS16 support proper
Date: Thu, 24 Jan 2013 13:13:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1301241253570.4834@tp.orcam.me.uk> (raw)
In-Reply-To: <5101086C.2000107@codesourcery.com>
On Thu, 24 Jan 2013, Chung-Lin Tang wrote:
> >> > -void
> >> > -__longjmp (env_arg, val_arg)
> >> > +static void __attribute__ ((nomips16))
> >> > +____longjmp (env_arg, val_arg)
> >> > __jmp_buf env_arg;
> >> > int val_arg;
> >> > {
> >> > @@ -86,3 +86,5 @@ __longjmp (env_arg, val_arg)
> >> > /* Avoid `volatile function does return' warnings. */
> >> > for (;;);
> >> > }
> >> > +
> >> > +strong_alias (____longjmp, __longjmp);
> > Why is the renaming / alias needed?
> >
>
> This was because the declaration of __longjmp() in setjmp.h prohibited
> us from tagging it directly with __attribute__ ((nomips16)) locally;
> there will be a declaration inconsistent with header error.
Indeed, GCC goes through a great pain to enforce consistency between a
function's prototype and the corresponding definition as far as the mips16
and nomips16 attributes are concerned. On the other hand it is possible
to provide a prototype with neither attribute and freely choose the
instruction encoding used for the definition with either of the -mips16
and -mno-mips16 command line options applied when building the relevant
source file.
I have no idea where this dichotomy comes from -- Richard, do you happen
to know? I'd be happy to get enlightened.
Maciej
next prev parent reply other threads:[~2013-01-24 13:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 4:41 [PATCH 0/2] MIPS16: MIPS16 support Maciej W. Rozycki
2013-01-23 4:41 ` [PATCH 1/2] MIPS16: Allocate GLIBC_2.18 Maciej W. Rozycki
2013-01-23 4:42 ` [PATCH 2/2] MIPS16: MIPS16 support proper Maciej W. Rozycki
2013-01-23 17:22 ` Joseph S. Myers
2013-01-24 10:10 ` Chung-Lin Tang
2013-01-24 13:13 ` Maciej W. Rozycki [this message]
2013-01-24 13:56 ` Richard Sandiford
2013-02-20 16:19 ` [PATCH v2] MIPS: MIPS16 support Maciej W. Rozycki
2013-02-20 16:29 ` Joseph S. Myers
2013-02-27 1:38 ` [PATCH v3] " Maciej W. Rozycki
2013-02-27 17:50 ` Joseph S. Myers
2013-02-27 23:54 ` Maciej W. Rozycki
2013-01-24 18:08 ` [PATCH 2/2] MIPS16: MIPS16 support proper Ellcey, Steve
2013-01-25 5:14 ` Maciej W. Rozycki
2013-01-25 13:59 ` Richard Sandiford
2013-01-28 22:18 ` Steve Ellcey
2013-01-25 22:10 ` Steve Ellcey
2013-01-26 0:32 ` Maciej W. Rozycki
2013-01-28 17:36 ` Steve Ellcey
2013-01-28 17:56 ` Steve Ellcey
2013-01-28 21:08 ` Maciej W. Rozycki
2013-01-28 18:58 ` Richard Henderson
2013-01-28 21:06 ` Maciej W. Rozycki
2013-01-28 21:17 ` Steve Ellcey
2013-01-29 16:24 ` Richard Henderson
2013-01-29 19:27 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1301241253570.4834@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=cltang@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).