From: "Joseph S. Myers" <joseph@codesourcery.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: <libc-ports@sourceware.org>,
Chung-Lin Tang <cltang@codesourcery.com>,
Steve Ellcey <Steve.Ellcey@imgtec.com>,
Richard Sandiford <rdsandiford@googlemail.com>
Subject: Re: [PATCH v2] MIPS: MIPS16 support
Date: Wed, 20 Feb 2013 16:29:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1302201625480.28917@digraph.polyomino.org.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1302201557510.6762@tp.orcam.me.uk>
On Wed, 20 Feb 2013, Maciej W. Rozycki wrote:
> * sysdeps/mips/fpu_control.h (__fpu_getcw) [__mips16]: New
> prototype.
> (__fpu_setcw) [__mips16]: Likewise.
Since you've renamed the functions to __mips_fpu_getcw and
__mips_fpu_setcw, you need to update the ChangeLog entry accordingly.
The ChangeLog entries may also need updates for other changes in this
patch version.
> * sysdeps/mips/mips32/mips16/fpu/Versions: New file.
Actually you moved the Versions file to the correct place for the symbol
versions not to depend on whether glibc itself is built as MIPS16. But
the contents of the file - and of the libc.abilist changes - need updating
for the new symbol names.
(Given these inconsistencies, I haven't fully reviewed the rest of the
patch contents.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-02-20 16:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 4:41 [PATCH 0/2] MIPS16: " Maciej W. Rozycki
2013-01-23 4:41 ` [PATCH 1/2] MIPS16: Allocate GLIBC_2.18 Maciej W. Rozycki
2013-01-23 4:42 ` [PATCH 2/2] MIPS16: MIPS16 support proper Maciej W. Rozycki
2013-01-23 17:22 ` Joseph S. Myers
2013-01-24 10:10 ` Chung-Lin Tang
2013-01-24 13:13 ` Maciej W. Rozycki
2013-01-24 13:56 ` Richard Sandiford
2013-02-20 16:19 ` [PATCH v2] MIPS: MIPS16 support Maciej W. Rozycki
2013-02-20 16:29 ` Joseph S. Myers [this message]
2013-02-27 1:38 ` [PATCH v3] " Maciej W. Rozycki
2013-02-27 17:50 ` Joseph S. Myers
2013-02-27 23:54 ` Maciej W. Rozycki
2013-01-24 18:08 ` [PATCH 2/2] MIPS16: MIPS16 support proper Ellcey, Steve
2013-01-25 5:14 ` Maciej W. Rozycki
2013-01-25 13:59 ` Richard Sandiford
2013-01-28 22:18 ` Steve Ellcey
2013-01-25 22:10 ` Steve Ellcey
2013-01-26 0:32 ` Maciej W. Rozycki
2013-01-28 17:36 ` Steve Ellcey
2013-01-28 17:56 ` Steve Ellcey
2013-01-28 21:08 ` Maciej W. Rozycki
2013-01-28 18:58 ` Richard Henderson
2013-01-28 21:06 ` Maciej W. Rozycki
2013-01-28 21:17 ` Steve Ellcey
2013-01-29 16:24 ` Richard Henderson
2013-01-29 19:27 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1302201625480.28917@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Steve.Ellcey@imgtec.com \
--cc=cltang@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=macro@codesourcery.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).