From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: Fix MIPS n32 cancellation in static libc (bug 15506)
Date: Tue, 21 May 2013 20:03:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1305212056520.26443@tp.orcam.me.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.1305202307160.18212@digraph.polyomino.org.uk>
On Tue, 21 May 2013, Joseph S. Myers wrote:
> Bug 15506 is missing cancellation wrappers in static MIPS n32 glibc
> when GCC is configured with --with-mips-plt, as referred to by
> <http://sourceware.org/ml/libc-ports/2012-02/msg00056.html> but with
> apparently no bug report filed in Bugzilla at that time.
>
> This patch fixes this by creating a non-PIC version of the n32/n64
> sysdep-cancel.h PSEUDO macro. Tested with NPTL tests for n32 (GCC
> --with-mips-plt), where it fixes failures of tst-cancel21-static and
> tst-cancel-wrappers. Maciej, does this patch seem sane to you?
Functionally it looks about right to me. Eventually I think it would be
good to merge the two PSEUDO macro variants along the lines of how
ports/sysdeps/unix/sysv/linux/mips/nptl/sysdep-cancel.h does it. Also
formatting of PSEUDO is weird in both files (a preexisting problem).
Thanks for fixing this issue.
Maciej
prev parent reply other threads:[~2013-05-21 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 23:10 Joseph S. Myers
2013-05-21 20:03 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1305212056520.26443@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).