From: Andreas Schwab <schwab@suse.de>
To: David Holsgrove <david.holsgrove@xilinx.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
Roland McGrath <roland@hack.frob.com>,
Joseph Myers <joseph@codesourcery.com>,
John Williams <jwilliams@xilinx.com>,
Edgar Iglesias <edgari@xilinx.com>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>, Tom Shui <tshui@xilinx.com>
Subject: Re: [PATCH v2 2/2] Add MicroBlaze Port
Date: Tue, 09 Apr 2013 08:32:00 -0000 [thread overview]
Message-ID: <mvm7gkc2jfr.fsf@hawking.suse.de> (raw)
In-Reply-To: <07006b79-5868-4bde-ba30-5739c3e3857f@CH1EHSMHS018.ehs.local> (David Holsgrove's message of "Tue, 9 Apr 2013 08:20:00 +0000")
David Holsgrove <david.holsgrove@xilinx.com> writes:
> +inline long
> +get_frame_size (unsigned long instr)
> +{
> + return abs ((short signed) (instr & 0xFFFF));
> +}
> +
> +static unsigned long *
> +find_frame_creation (unsigned long *pc)
> +{
> + int i;
Two spaces indent.
> +
> + /* NOTE: Distance to search is arbitrary
> + * 250 works well for most things,
> + * 750 picks up things like tcp_recvmsg(),
> + * 1000 needed for fat_fill_super(). */
No initial * in comments. No () when referring to functions, instead of
actual calls.
> + if ((!(*pprev_pc) || ((*pprev_pc) & 3)))
The innermost parens are confusing and redundant, likewise for the outer
pair.
> + array[0]=(void *)pc;
Space around operators and after the cast.
> +#define atomic_compare_and_exchange_val_acq(mem, newval, oldval) \
> + ({ \
> + __typeof (*(mem)) __result; \
> + if (sizeof (*mem) == 4) \
> + __result = __arch_compare_and_exchange_val_32_acq(mem, newval, oldval); \
Space before open paren.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2013-04-09 8:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364652885-28535-1-git-send-email-david.holsgrove@xilinx.com>
2013-03-30 14:30 ` [PATCH v2 1/2] Add MicroBlaze support to elf/elf.h David Holsgrove
2013-04-08 22:15 ` Roland McGrath
2013-04-09 7:41 ` David Holsgrove
2013-04-11 20:25 ` Roland McGrath
2013-04-12 0:33 ` David Holsgrove
2013-03-30 14:31 ` [PATCH v2 2/2] Add MicroBlaze Port David Holsgrove
2013-04-02 23:49 ` Joseph S. Myers
2013-04-09 8:20 ` David Holsgrove
2013-04-09 8:32 ` Andreas Schwab [this message]
2013-04-11 7:58 ` David Holsgrove
2013-04-16 0:51 ` David Holsgrove
2013-04-17 0:18 ` David Holsgrove
2013-04-17 7:47 ` Andreas Schwab
2013-04-18 7:23 ` David Holsgrove
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm7gkc2jfr.fsf@hawking.suse.de \
--to=schwab@suse.de \
--cc=david.holsgrove@xilinx.com \
--cc=edgari@xilinx.com \
--cc=joseph@codesourcery.com \
--cc=jwilliams@xilinx.com \
--cc=libc-ports@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=roland@hack.frob.com \
--cc=tshui@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).