public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* nptl/sysdeps/*/tls.h
@ 2012-12-04 15:15 Игорь Пашев
  2012-12-04 15:29 ` nptl/sysdeps/*/tls.h Ryan S. Arnold
  0 siblings, 1 reply; 3+ messages in thread
From: Игорь Пашев @ 2012-12-04 15:15 UTC (permalink / raw)
  To: libc-ports

/* Please CC me */


Hi, all.

I'm looking at tls.h for x86/x86_64, [1] and [2], and it includes
linux specific syscalls ("set_thread_area" and "arch_prctl").

Does it make sense to split [1] and [2] into common parts (for
x86/x86_64) and linux-specific
so other non-linux ports could inherit common parts?

Of course if it is possible at all.

[1] http://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/sysdeps/i386/tls.h;h=90c7a534bfd0ed16f48266f55c36c31ab36ac623;hb=HEAD
[2] http://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/sysdeps/x86_64/tls.h;h=f3b76495b303597ccbbb8feb2345b97befa1bda7;hb=HEAD

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nptl/sysdeps/*/tls.h
  2012-12-04 15:15 nptl/sysdeps/*/tls.h Игорь Пашев
@ 2012-12-04 15:29 ` Ryan S. Arnold
  2012-12-04 16:15   ` nptl/sysdeps/*/tls.h Andreas Schwab
  0 siblings, 1 reply; 3+ messages in thread
From: Ryan S. Arnold @ 2012-12-04 15:29 UTC (permalink / raw)
  To: Игорь Пашев
  Cc: libc-ports

The canonical way to handle this would be to put the OS specific parts
of the header into an installed bits/tls.h file and then #include
<bits/tls.h> in the regular tls.h file.

Whether this is something the maintainers want is a different question
that others will have to answer.

Ryan S. Arnold

On Tue, Dec 4, 2012 at 9:14 AM, Игорь Пашев <pashev.igor@gmail.com> wrote:
> /* Please CC me */
>
>
> Hi, all.
>
> I'm looking at tls.h for x86/x86_64, [1] and [2], and it includes
> linux specific syscalls ("set_thread_area" and "arch_prctl").
>
> Does it make sense to split [1] and [2] into common parts (for
> x86/x86_64) and linux-specific
> so other non-linux ports could inherit common parts?
>
> Of course if it is possible at all.
>
> [1] http://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/sysdeps/i386/tls.h;h=90c7a534bfd0ed16f48266f55c36c31ab36ac623;hb=HEAD
> [2] http://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/sysdeps/x86_64/tls.h;h=f3b76495b303597ccbbb8feb2345b97befa1bda7;hb=HEAD

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nptl/sysdeps/*/tls.h
  2012-12-04 15:29 ` nptl/sysdeps/*/tls.h Ryan S. Arnold
@ 2012-12-04 16:15   ` Andreas Schwab
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2012-12-04 16:15 UTC (permalink / raw)
  To: Ryan S. Arnold
  Cc: Игорь
	Пашев,
	libc-ports

"Ryan S. Arnold" <ryan.arnold@gmail.com> writes:

> The canonical way to handle this would be to put the OS specific parts
> of the header into an installed bits/tls.h file and then #include
> <bits/tls.h> in the regular tls.h file.

tls.h is an internal header, so this should use a different style.  In
this case it it ok to use #include <.../tls.h> directly (which some
already do).

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-04 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-04 15:15 nptl/sysdeps/*/tls.h Игорь Пашев
2012-12-04 15:29 ` nptl/sysdeps/*/tls.h Ryan S. Arnold
2012-12-04 16:15   ` nptl/sysdeps/*/tls.h Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).