From: Stefan Liebler <stli@linux.ibm.com>
To: libc-stable@sourceware.org
Cc: libc-alpha@sourceware.org
Subject: [2.30 COMMITTED] S390: Fix handling of needles crossing a page in strstr z15 ifunc-variant. [BZ #25226]
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <32472cf3-4e0b-2835-c8e9-b289219e4785@linux.ibm.com> (raw)
In-Reply-To: <4d03632f-1339-2e81-2418-18a6e0b31b8d@linux.ibm.com>
On 11/27/19 12:53 PM, Stefan Liebler wrote:
> On 11/27/19 10:33 AM, Florian Weimer wrote:
>> * Stefan Liebler:
>>
>>> if the specified needle crosses a page-boundary, the s390-z15 ifunc
>>> variant of strstr truncates the needle which results in invalid
>>> results.
>>>
>>> This is fixed by loading the needle beyond the page boundary to v18
>>> instead of v16. The bug is sometimes observable in test-strstr.c in
>>> check1() and check2() as the haystack and needle is stored on
>>> stack. Thus the needle can be on a page boundary.
>>
>> (GNU style is âcheck1 and check2â, no parentheses.)
>>
>>> check2 is now extended to test haystack / needles located on stack, at
>>> end of page and on two pages.
>>
>> The test change looks okay to me. I haven't reviewed the assembler
>> change. I think you can commit that as the architecture maintainer.
>>
>> We will need help from your team with testing the downstream fix. Do
>> you think we should fix this proactively in Red Hat Enterprise Linux 8.1
>> as well? It received the backport of the new strstr implementation,
>> too.
>>
>> Thanks,
>> Florian
>>
>
> Committed it with âcheck1 and check2â and a reference to the commit
> 6f47401bd5fc71209219779a0426170a9a7395b0.
>
> Regarding RHEL, I've recognized that you've opened a RHEL Bugzilla and
> answered there.
>
> Thanks,
> Stefan
>
I've just committed
https://sourceware.org/git/?p=glibc.git;a=commit;h=f4419b0d0181da28f18cba40068f2e75300f5020
parent reply other threads:[~2019-11-27 11:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4d03632f-1339-2e81-2418-18a6e0b31b8d@linux.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32472cf3-4e0b-2835-c8e9-b289219e4785@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).