From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, libc-stable@sourceware.org
Subject: Re: Backporting CVE-2016-10739
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <47ca567f-7120-19c5-7ed6-c67c9f6306ca@redhat.com> (raw)
In-Reply-To: <87munbo8wy.fsf@oldenburg2.str.redhat.com>
On 2/4/19 10:44 AM, Florian Weimer wrote:
> * Carlos O'Donell:
>
>>> +#include <arpa/inet.h>
>>> +
>>
>> Please add a comment explaining why this is here.
>
> You mean like this?
>
> /* Obtain the prototype for __inet_aton_exact. */
It should reference the bug or CVE to document the intent
of the changes.
Post v3 and I'll sign off?
>>> +/* Declare __inet_aton_exact as hidden, so that it does not get
>>> + exported from nscd. */
>>> +__typeof__ (__inet_aton_exact) __inet_aton_exact attribute_hidden;
>>> +
>>> +/* Do not provide definitions of the public symbols exported from
>>> + libc. */
>>> +#undef weak_alias
>>> +#define weak_alias(from, to)
>>> +
>>> +#include <resolv/inet_addr.c>
>>
>> Can we kill the prototype from the public header and use an internal
>> header? It seems messy to leave that prototype for the GLIBC_PRIVATE
>> symbol in the public header. It might tempt people to workaround the
>> linkage protection.
>
> I don't understand. There is no public header. We can't remove it from
> the internal header because it would break the test suite build.
Perfect, I thought I saw this in a public header. If it's not then we
don't have anything else to do. Your patch is the best solution.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2019-02-04 15:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Aurelien Jarno
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell [this message]
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Aurelien Jarno
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Aurelien Jarno
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ca567f-7120-19c5-7ed6-c67c9f6306ca@redhat.com \
--to=carlos@redhat.com \
--cc=aurelien@aurel32.net \
--cc=fweimer@redhat.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).