From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, libc-stable@sourceware.org
Subject: Re: Backporting CVE-2016-10739
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <87h8djl16h.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <2e644830-b506-f5b6-e020-99fc9ee9b94f@redhat.com> (Carlos O'Donell's message of "Mon, 4 Feb 2019 14:58:39 -0500")
* Carlos O'Donell:
>> Patch below. What do you think?
>
> This looks good to me, you make direct use of "__attribute__
> ((visibility ("hidden")))" in an exceptional case, and that's fine.
> If this becomes less rare for some reason we might want a
> libc-symbols.h macro to define something that expresses the intent of
> the hidden visibility e.g. attr_dup_sym_hidden.
I'm not a firm believer in those macros. The fact that attribute_hidden
expanded to nothing at all was quite a surprise to me.
I've pushed the last version.
Aurelien, I will not be able to do any more backports before Wednesday,
so please feel free to take over.
Thanks,
Florian
next prev parent reply other threads:[~2019-02-04 21:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 Aurelien Jarno
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Aurelien Jarno
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Aurelien Jarno
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Florian Weimer [this message]
2019-01-01 0:00 ` Carlos O'Donell
2019-01-01 0:00 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8djl16h.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=aurelien@aurel32.net \
--cc=carlos@redhat.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).