From: Rafal Luzynski <digitalfreak@lingonborough.com>
To: Carlos O'Donell <carlos@redhat.com>, libc-stable@sourceware.org
Subject: Re: [PATCH 5/5] NEWS: Add entries for bugs: 22848, 22932, 22937, 22963.
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <689420158.50213.1521148010464@poczta.nazwa.pl> (raw)
In-Reply-To: <ee91a4ac-a4ca-69f7-af4f-f2e8750c457e@redhat.com>
15.03.2018 18:39 Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 03/15/2018 05:23 AM, Rafal Luzynski wrote:
> > [...]
> > +Major new features:
> > +
> > +* As a continuation of the previous work on bug 10871 (supporting
> > nominative
> > + and genitive month names) alternative month data have been added for the
> > + Catalan and Czech language. For the Catalan language the abbreviated
> > + alternative month name data has been also added. The Greek language which
> > + had had alternative month names already has received the abbreviated
> > + alternative month names.
>
> Suggest:
>
> * Nominative and genitive month names are now supported for the Catalan and
> Czech languages. The Catalan and Greek languages now support abbreviated
> alternative month names.
Thank you Carlos for this review and thank you Joseph for the discussion.
Is "supported"/"support" the correct word? IIUC this sounds like a new
software feature while I'm only adding new data. Wouldn't "provided" be
better, or "added" or "included"? Also I think it would be better to use
the consequent wording "nominative/genitive" vs. "alternative".
Just please confirm if "supported" is correct.
> [...]
> If these bug fixes need a news entry, then there should be a news entry in
> glibc
> master NEWS *first* before you add it here.
OK, good point.
> > [...]
> > + [22848] ca_ES: update date definitions from CLDR
>
> Not marked fixed in 2.28 (target milestone should be set to 2.28 and marked
> fixed).
I was going to ask if it should be marked as fixed in 2.28 or 2.27.1
(there is no such option in Bugzilla) or 2.27. Also I was going to mark
as fixed after pushing to 2.27. The same about other bugs.
> [...]
> Next steps:
>
> - Commit a NEWS update to glibc master.
> - Mark all bugs fixed with milestone set to glibc 2.28.
> - Commit the same NEWS entry in 2.27.
> - Commit all the changes (will automatically add comments to bugzilla
> that they were also fixed in release/2.27/master).
OK, just please confirm the correct wording in NEWS and the correct
target milestone in Bugzilla.
Regards,
Rafal
next prev parent reply other threads:[~2018-03-15 21:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 0:00 [PATCH 0/5] Backport of fixes " Rafal Luzynski
2018-01-01 0:00 ` [PATCH 5/5] NEWS: Add entries " Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Joseph Myers
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Joseph Myers
2018-01-01 0:00 ` [PATCH v2 5/5][COMMITTED] " Rafal Luzynski
2018-01-01 0:00 ` Rafal Luzynski [this message]
2018-01-01 0:00 ` [PATCH 5/5] " Joseph Myers
2018-01-01 0:00 ` Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` [PATCH 4/5] cs_CZ locale: Add alternative month names (bug 22963) Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Rafal Luzynski
2018-01-01 0:00 ` [PATCH 3/5] Greek (el_CY, el_GR) locales: Introduce ab_alt_mon (bug 22937) Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Rafal Luzynski
2018-01-01 0:00 ` [PATCH 2/5] lt_LT locale: Update abbreviated month names (bug 22932) Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Rafal Luzynski
2018-01-01 0:00 ` [PATCH 1/5] ca_ES locale: Update LC_TIME (bug 22848) Rafal Luzynski
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Rafal Luzynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=689420158.50213.1521148010464@poczta.nazwa.pl \
--to=digitalfreak@lingonborough.com \
--cc=carlos@redhat.com \
--cc=libc-stable@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).