From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: Raphael Moreira Zinsly <rzinsly@linux.vnet.ibm.com>
Cc: libc-stable@sourceware.org, carlos@redhat.com, arjun.is@lostca.se
Subject: Re: [PATCH 2.22] posix: Sync glob with gnulib [BZ #1062]
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <87vacvhsal.fsf@linux.ibm.com> (raw)
In-Reply-To: <1523558235-30943-1-git-send-email-rzinsly@linux.vnet.ibm.com>
Raphael Moreira Zinsly <rzinsly@linux.vnet.ibm.com> writes:
> This patch syncs posix/glob.c implementation with gnulib version
> b5ec983 (glob: simplify symlink detection). The only difference
> to gnulib code is
>
> * DT_UNKNOWN, DT_DIR, and DT_LNK definition in the case there
> were not already defined. Gnulib code which uses
> HAVE_STRUCT_DIRENT_D_TYPE will redefine them wrongly because
> GLIBC does not define HAVE_STRUCT_DIRENT_D_TYPE. Instead
> the patch check for each definition instead.
>
> Also, the patch requires additional globfree and globfree64 files
> for compatibility version on some architectures. Also the code
> simplification leads to not macro simplification (not need for
> NO_GLOB_PATTERN_P anymore).
>
> Checked on x86_64-linux-gnu and on a build using build-many-glibcs.py
> for all major architectures.
LGTM.
With this patch, I could merge the following patches:
[PATCH 2.22 02/14] CVE-2017-15670: glob: Fix one-byte overflow [BZ #22320]
[PATCH 2.22 03/14] glob: Add new test tst-glob-tilde
[PATCH 2.22 05/14] glob: Fix buffer overflow during GLOB_TILDE unescaping [BZ #22332]
If there are any objections, I plan to merge it next Tuesday.
After merging these patches, the following patch would still be pending from
your initial submission:
[PATCH 2.22 11/14] linux: make getcwd(3) fail if it cannot obtain an absolute path [BZ #22679]
Thanks!
--
Tulio Magno
next prev parent reply other threads:[~2018-04-13 18:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 0:00 [PATCH 2.22 01/14] ldd: never run file directly Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 06/14] elf: Check for empty tokens before dynamic string token expansion [BZ #22625] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 11/14] linux: make getcwd(3) fail if it cannot obtain an absolute path [BZ #22679] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 09/14] elf: Compute correct array size in _dl_init_paths [BZ #22606] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 03/14] glob: Add new test tst-glob-tilde Raphael Moreira Zinsly
2018-01-01 0:00 ` Tulio Magno Quites Machado Filho
2018-01-01 0:00 ` [PATCH 2.22] Synchronize support/ infrastructure with master Raphael Moreira Zinsly
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Tulio Magno Quites Machado Filho
2018-01-01 0:00 ` [PATCH 2.22] posix: Sync glob with gnulib [BZ #1062] Raphael Moreira Zinsly
2018-01-01 0:00 ` Tulio Magno Quites Machado Filho [this message]
2018-01-01 0:00 ` [PATCH 2.22 10/14] Fix integer overflows in internal memalign and malloc functions [BZ #22343] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 v2] " Raphael Moreira Zinsly
2018-01-01 0:00 ` Carlos O'Donell
[not found] ` <20180405194944.GA44061@aloka.lostca.se>
2018-01-01 0:00 ` Carlos O'Donell
2018-01-01 0:00 ` Tulio Magno Quites Machado Filho
2018-01-01 0:00 ` [PATCH 2.22 05/14] glob: Fix buffer overflow during GLOB_TILDE unescaping [BZ #22332] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 08/14] <array_length.h>: New array_length and array_end macros Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 14/14] Record CVE-2018-6551 in NEWS and ChangeLog [BZ #22774] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 01/14] ldd: never run file directly Carlos O'Donell
2018-01-01 0:00 ` Tulio Magno Quites Machado Filho
2018-01-01 0:00 ` [PATCH 2.22 13/14] Record CVE-2018-6485 in ChangeLog and NEWS [BZ #22343] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 04/14] sunrpc: Avoid use-after-free read access in clntudp_call [BZ #21115] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 02/14] CVE-2017-15670: glob: Fix one-byte overflow [BZ #22320] Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 12/14] Add ChangeLog reference to bug 16750/CVE-2009-5064 Raphael Moreira Zinsly
2018-01-01 0:00 ` [PATCH 2.22 07/14] elf: Count components of the expanded path in _dl_init_path [BZ #22607] Raphael Moreira Zinsly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vacvhsal.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=arjun.is@lostca.se \
--cc=carlos@redhat.com \
--cc=libc-stable@sourceware.org \
--cc=rzinsly@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).