From: "H.J. Lu" <hjl.tools@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Sunil K Pandey <skpgkp2@gmail.com>,
Libc-stable Mailing List <libc-stable@sourceware.org>
Subject: Re: [PATCH] x86-64: Simplify minimum ISA check ifdef conditional with if
Date: Sat, 13 Apr 2024 11:04:44 -0700 [thread overview]
Message-ID: <CAMe9rOo4OqSU5J8JukmsKp5Fo8_2jE1VbBVB_Png3aoorkpHSQ@mail.gmail.com> (raw)
In-Reply-To: <87h6g51773.fsf@oldenburg.str.redhat.com>
On Sat, Apr 13, 2024 at 10:52 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > Should it also be backported to glibc 2.39 together with
> >
> > commit befe2d3c4dec8be2cdd01a47132e47bdb7020922
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Wed Feb 28 09:51:14 2024 -0800
> >
> > x86-64: Don't use SSE resolvers for ISA level 3 or above
>
> This is the one that breaks valgrind, isn't it?
No. -march=x86-64-v3 triggers the valgrind error in flibc test. This
commit fixes the -march=x86-64-v3 build.
commit b6e3898194bbae78910bbe9cd086937014961e45
Author: Sunil K Pandey <skpgkp2@gmail.com>
Date: Thu Feb 29 17:57:02 2024 -0800
x86-64: Simplify minimum ISA check ifdef conditional with if
updates this commit. Backporting the above commit makes the
backported code look similar to upstream.
> I think we'll do downstream backports of some of the x86-64
> optimizations, but in the past, there was pushback against doing those
> upstream.
>
> Thanks,
> Florian
>
--
H.J.
next prev parent reply other threads:[~2024-04-13 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMAf5_fVOYmBsTsfNHNQOBXjLYRF=NQ2gAduJMFwkPOMcW4yCw@mail.gmail.com>
[not found] ` <20240302003843.3333713-1-skpgkp2@gmail.com>
[not found] ` <CAMe9rOr6tLZ5Na8XN1QMa4zO2kNw1+cW2E9g=-wat+tQVNqNAA@mail.gmail.com>
2024-04-13 15:59 ` H.J. Lu
2024-04-13 17:52 ` Florian Weimer
2024-04-13 18:04 ` H.J. Lu [this message]
2024-04-13 18:22 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOo4OqSU5J8JukmsKp5Fo8_2jE1VbBVB_Png3aoorkpHSQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-stable@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).