* Re: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
[not found] ` <CAMe9rOohkO06iCdC1UTwkvhw6i4HZOEzZT1zEi4NvED5+6qwOw@mail.gmail.com>
@ 2022-01-27 17:06 ` H.J. Lu
0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2022-01-27 17:06 UTC (permalink / raw)
To: Florian Weimer, Libc-stable Mailing List; +Cc: H.J. Lu via Libc-alpha
On Sat, Mar 27, 2021 at 10:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Mar 27, 2021 at 10:52 AM Florian Weimer <fw@deneb.enyo.de> wrote:
> >
> > * H. J. Lu:
> >
> > > Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
> > >
> > > Use wmemset to initialize wchar_t string.
> > > ---
> > > string/test-strnlen.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> > > index a49d93afa2..b98dc10a56 100644
> > > --- a/string/test-strnlen.c
> > > +++ b/string/test-strnlen.c
> > > @@ -27,6 +27,7 @@
> > >
> > > #ifndef WIDE
> > > # define STRNLEN strnlen
> > > +# define MEMSET memset
> > > # define CHAR char
> > > # define BIG_CHAR CHAR_MAX
> > > # define MIDDLE_CHAR 127
> > > @@ -34,6 +35,7 @@
> > > #else
> > > # include <wchar.h>
> > > # define STRNLEN wcsnlen
> > > +# define MEMSET wmemset
> > > # define CHAR wchar_t
> > > # define BIG_CHAR WCHAR_MAX
> > > # define MIDDLE_CHAR 1121
> > > @@ -153,7 +155,7 @@ do_page_tests (void)
> > > size_t last_offset = (page_size / sizeof (CHAR)) - 1;
> > >
> > > CHAR *s = (CHAR *) buf2;
> > > - memset (s, 65, (last_offset - 1));
> > > + MEMSET (s, 65, (last_offset - 1));
> > > s[last_offset] = 0;
> > >
> > > /* Place short strings ending at page boundary. */
> >
> > Patch looks good. Please change the commit message to mention that
> > this changes just a test.
>
> I changed the commit subject to
>
> test-strnlen.c: Initialize wchar_t string with wmemset [BZ #27655]
>
> --
> H.J.
I am backporting this to release branches.
--
H.J.
^ permalink raw reply [flat|nested] only message in thread